Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose HAProxy config template var w/ Voyager deployment.spec.replicas #517

Closed
julianvmodesto opened this issue Sep 20, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@julianvmodesto
Copy link
Contributor

commented Sep 20, 2017

When configuring options in HAProxy config like maxconn, I would like to be specify a true global maxconn across all Voyager HAProxies.

For example, if I set maxconn 2000 in the ingress.spec.frontendRules, this maxconn is for a single HAProxy. But when I have scaled my deployment/voyager-api --replicas=2, maxconn is really 2000 * 2 replicas.

If there was a template variable available for use in my Ingress spec w/ the number of replicas in deployment/voyager-api, I could better tune maxconn e.g. maxconn {{.VoyagerReplicas}}.

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Sep 25, 2017

I am a bit puzzled by this issue. If you are scaling up Voyager, you should scale up the backend services to handle the extra load. Is there a reason you are not doing that?

@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2017

Hmm I'm not sure, yes we should be scaling backends instead... Sorry, closing this. :)

@julianvmodesto

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2017

Turns out we're scaling frontend voyager pods occasionally due to global maxconn per voyager pod getting hit.

Would be interesting to get deployment.spec.replicas via the downward api.

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Mar 6, 2018

Dup #314

@tamalsaha tamalsaha closed this Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.