Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support imagePullSecrets for HAProxy pods #673

Closed
Hiruma31 opened this issue Nov 2, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@Hiruma31
Copy link

commented Nov 2, 2017

Hello,

As mentioned on slack, I can't pull the HAProxy image from my internal registry since hub.docker.com isn't reachable from my cluster.

I specify the image using --haproxy-image=$MY_REGISTRY/voyager/haproxy:1.7.9-5.0.0-rc.1 in Voyager's deployment. However, when an Ingress is created and the voyager-$INGRESS deployment pod starts, it tries to pull the said image from the registry, but fails since it doesn't have the imagePullSecret.

Thanks again !

tamalsaha added a commit that referenced this issue Nov 2, 2017

tamalsaha added a commit that referenced this issue Nov 2, 2017

tamalsaha added a commit that referenced this issue Nov 2, 2017

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Nov 3, 2017

This has been added to 5.0.0-rc.3. Please give it a shot.

To use your private image as voyager operator and sidecar exporter, use flags:

--exporter-sidecar-image string         Docker image containing Prometheus exporter (default "appscode/voyager:5.0.0-rc.3")
--haproxy-image string                  Docker image containing HAProxy binary (default "appscode/haproxy:1.7.9-5.0.0-rc.3")

To pass imagePullSecrets, set it in the Ingress spec:

apiVersion: voyager.appscode.com/v1beta1
kind: Ingress
metadata:
  name: test-ingress
  namespace: default
  annotations:
    ingress.appscode.com/type: NodePort
    ingress.appscode.com/force-service-port: "false"
    ingress.appscode.com/stats: "true"
spec:
  imagePullSecrets:
    - name: my-registry-auth
  rules:
  - http:
      - path: /
        backend:
          serviceName: test-server
          servicePort: 80
@Hiruma31

This comment has been minimized.

Copy link
Author

commented Nov 3, 2017

Worked like a charm, thanks a lot for the quick addition ! 👍

tamalsaha added a commit that referenced this issue Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.