Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default http->https redirect turns DELETE (and possibly other HTTP verbs) into GET #816

Closed
drf opened this issue Jan 22, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@drf
Copy link
Collaborator

commented Jan 22, 2018

Not sure if this is a HAProxy or Voyager bug. When bringing up a standard TLS host rule, http/80 correctly forwards to https. However, if you try to do any operation, such as "DELETE /sth", the redirect will turn into "GET /sth" on https.

@drf drf changed the title Default http->https redirect turns all HTTP verbs into GET Default http->https redirect turns DELETE (and possibly other HTTP verbs) into GET Jan 30, 2018

@drf

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 30, 2018

Updated the description - PUT and POST are actually fine, whereas DELETE gets converted into a GET. With the right guidance I could try and provide a patch @tamalsaha

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Feb 7, 2018

@drf, I have changed the redirect code to 308. According to https://www.haproxy.com/documentation/aloha/7-0/traffic-management/lb-layer7/http-redirection/ , this will preserve original verb. Thanks for finding this issue.

@drf

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 7, 2018

Great catch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.