Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MetalLB #970

Closed
schubter opened this issue Apr 5, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@schubter
Copy link
Contributor

commented Apr 5, 2018

i am running MetalLB (https://metallb.universe.tf) on our baremetal clusters with great success and get a LoadBalancer IP assigned even for the voyager service

$ kubectl get svc NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE kubernetes ClusterIP 10.96.0.1 <none> 443/TCP 211d voyager-intranet LoadBalancer 10.105.155.17 xx.xx.xx.31 80:31647/TCP 22h

but the haproxy pod keeps crashing with:
F0405 09:18:34.566804 8 haproxy.go:61] [ingress default/intranet uses unsupported LBType LoadBalancer for cloud provider ]

is there a possibility to either include MetalLB as cloudprovider or change the check if a LB-IP has been assigned?

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

If you return true from this switch https://github.com/appscode/voyager/blob/master/apis/voyager/v1beta1/validator.go#L283 , this should work.

@schubter

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

thats what i figured, i wasn't sure if there are more things that the cloud provider setting does.
if thats the only thing, do you want me to open a PR?

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Sure, do you mind trying with your custom build? The build process is described here: https://github.com/appscode/voyager/blob/master/docs/setup/developer-guide/overview.md

@schubter

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

sure, gladly. i have some other things to attend right now but i should have a pr open after confirming that it works correctly later today.

thanks for the quick response

@schubter schubter closed this Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.