Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nodeport service url for minikube #1001

Merged
merged 1 commit into from Apr 27, 2018

Conversation

@diptadas
Copy link
Contributor

diptadas commented Apr 27, 2018

fixes #1000

diptadas
@diptadas diptadas requested a review from tamalsaha Apr 27, 2018
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #1001 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1001   +/-   ##
======================================
  Coverage    3.56%   3.56%           
======================================
  Files          51      51           
  Lines       18034   18034           
======================================
  Hits          643     643           
  Misses      17263   17263           
  Partials      128     128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53bad1...5567a73. Read the comment docs.

@tamalsaha tamalsaha merged commit 83e9840 into master Apr 27, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tamalsaha tamalsaha deleted the svc-url branch Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.