Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minikube urls for LB type hostport #1003

Merged
merged 2 commits into from May 3, 2018

Conversation

Projects
None yet
3 participants
@diptadas
Copy link
Contributor

commented Apr 28, 2018

  • For LoadBalancer / NoderPort url = <minikube-ip>:<service-node-port>
  • For HostPort (headless service) url = <minikube-ip>:<service-port>

@diptadas diptadas requested a review from tamalsaha Apr 28, 2018

diptadas and others added some commits Apr 28, 2018

@tamalsaha tamalsaha force-pushed the minikube-url branch from 6e47c7a to 70129a7 May 3, 2018

@tamalsaha tamalsaha merged commit 3e506a0 into master May 3, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the minikube-url branch May 3, 2018

@codecov-io

This comment has been minimized.

Copy link

commented May 3, 2018

Codecov Report

Merging #1003 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1003   +/-   ##
======================================
  Coverage    3.54%   3.54%           
======================================
  Files          52      52           
  Lines       18005   18005           
======================================
  Hits          638     638           
  Misses      17245   17245           
  Partials      122     122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f82002...70129a7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.