Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find TLS secret only if NoTLS=false #1041

Merged
merged 1 commit into from May 12, 2018

Conversation

@diptadas
Copy link
Contributor

commented May 11, 2018

No description provided.

diptadas

@diptadas diptadas requested a review from tamalsaha May 11, 2018

@codecov-io

This comment has been minimized.

Copy link

commented May 12, 2018

Codecov Report

Merging #1041 into master will decrease coverage by 0.01%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1041      +/-   ##
=========================================
- Coverage    3.76%   3.75%   -0.02%     
=========================================
  Files          52      52              
  Lines       18236   18234       -2     
=========================================
- Hits          687     685       -2     
  Misses      17420   17420              
  Partials      129     129
Impacted Files Coverage Δ
apis/voyager/v1beta1/port.go 24.59% <0%> (ø) ⬆️
apis/voyager/v1beta1/validator.go 50% <100%> (-1.22%) ⬇️
apis/voyager/v1beta1/diff.go 20.75% <100%> (+2.57%) ⬆️
pkg/ingress/parser.go 3.56% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa39e3d...88e60a2. Read the comment docs.

@tamalsaha tamalsaha merged commit e294059 into master May 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tamalsaha tamalsaha deleted the refactor branch May 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.