Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect analytics for voyager usages #133

Merged
merged 2 commits into from Jun 1, 2017

Conversation

Projects
None yet
3 participants
@sadlil
Copy link
Contributor

commented Jun 1, 2017

Fixes #126

@sadlil sadlil added this to the 1.5.6 milestone Jun 1, 2017

@sadlil sadlil self-assigned this Jun 1, 2017

@sadlil sadlil requested review from tamalsaha and aerokite Jun 1, 2017

@sadlil sadlil added the status/ready label Jun 1, 2017

@aerokite
Copy link
Contributor

left a comment

LGTM

@@ -32,4 +34,6 @@ func (s *Config) AddFlags(fs *pflag.FlagSet) {
fs.StringVarP(&s.LoadbalancerImageName, "haproxy-image", "h", s.LoadbalancerImageName, "haproxy image name to be run")

fs.StringVar(&s.IngressClass, "ingress-class", "", "Ingress class handled by voyager. Unset by default. Set to voyager to only handle ingress with annotation kubernetes.io/ingress.class=voyager.")

fs.BoolVar(&s.EnableAnalytics, "analytics", true, "Send analytical event to Google Analytics")

This comment has been minimized.

Copy link
@aerokite

aerokite Jun 1, 2017

Contributor

Use EnableAnalytics here instead of true directly.

fs.BoolVar(&s.EnableAnalytics, "analytics", EnableAnalytics, "Send analytical event to Google Analytics")
// without converting to specific type for each resource, we
// extract group version from resource SelfLink. This guaranties
// having GroupVersion.
gvk := e.MetaData.GetSelfLink()

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Jun 1, 2017

Member

Can you figure this out from ApiGroup & Name? Do we need to parse selfLink?

@tamalsaha tamalsaha merged commit a3cbaa8 into master Jun 1, 2017

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@tamalsaha tamalsaha deleted the analytics branch Jun 1, 2017

@tamalsaha tamalsaha referenced this pull request Jun 12, 2017

Closed

Document 1.5.6 changes #150

8 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.