Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove event framework #282

Merged
merged 50 commits into from Jul 12, 2017

Conversation

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented Jul 10, 2017

This will greatly simplify code base and make it easier to fix bugs.

@tamalsaha tamalsaha added this to the 3.1.0 milestone Jul 10, 2017

@tamalsaha tamalsaha requested a review from sadlil Jul 10, 2017

AddFunc: func(obj interface{}) {
if cert, ok := obj.(*sapi.Certificate); ok {
log.Infof("%s %s@%s added", cert.GroupVersionKind(), cert.Name, cert.Namespace)

This comment has been minimized.

Copy link
@sadlil

sadlil Jul 10, 2017

Contributor

cert controller not handling the event.

return
}

},

This comment has been minimized.

Copy link
@sadlil

sadlil Jul 10, 2017

Contributor

Needs to handle endpoint update with respect to ingress

promClient pcm.MonitoringV1alpha1Interface,
store stash.Storage,
ingressClass string,
operatorServiceAccount string) error {

This comment has been minimized.

Copy link
@sadlil

sadlil Jul 10, 2017

Contributor

consider moving all those parameter to option

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2017

RIP events framework!

@tamalsaha tamalsaha closed this Jul 12, 2017

@tamalsaha tamalsaha reopened this Jul 12, 2017

@tamalsaha tamalsaha merged commit 79b1cdb into master Jul 12, 2017

@tamalsaha tamalsaha deleted the remove-event-framework branch Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.