Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record events against TPR #290

Merged
merged 5 commits into from Jul 17, 2017

Conversation

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented Jul 12, 2017

Fixes #79

@tamalsaha tamalsaha added this to the 3.1.0 milestone Jul 12, 2017

@tamalsaha tamalsaha requested a review from sadlil Jul 12, 2017

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2017

@sadlil , can you add events when Deployments, services, servicmonitors are added?

@sadlil

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

what about update and delete? @tamalsaha

@sadlil sadlil dismissed their stale review via 7b99fd3 Jul 17, 2017

c.recorder.Eventf(c.tpr, apiv1.EventTypeWarning, "RenewFailed", "Failed to renew certificate, %s", err.Error())
return err
}
c.recorder.Eventf(c.tpr, apiv1.EventTypeWarning, "Renewed", "Successfully renewed certificate")

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Jul 17, 2017

Author Member

RenewSuccessful

c.renew()
err := c.renew()
if err != nil {
c.recorder.Eventf(c.tpr, apiv1.EventTypeWarning, "RenewFailed", "Failed to renew certificate, %s", err.Error())

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Jul 17, 2017

Author Member

, Reason: %s", err)

@tamalsaha tamalsaha merged commit 6112535 into master Jul 17, 2017

@tamalsaha tamalsaha deleted the d24 branch Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.