Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite #394

merged 21 commits into from Aug 19, 2017


None yet
2 participants
Copy link

commented Aug 15, 2017

Fixes #31

@sadlil sadlil self-assigned this Aug 15, 2017

@sadlil sadlil requested a review from tamalsaha Aug 15, 2017

@sadlil sadlil changed the title WIP: Improve test suite Improve test suite Aug 17, 2017


This comment has been minimized.

Copy link

commented Aug 19, 2017

I am going to merge this and cut a beta release for #400. I need that NodePort fix.

@tamalsaha tamalsaha merged commit a16709e into master Aug 19, 2017

@tamalsaha tamalsaha deleted the fix-tests branch Aug 19, 2017

tamalsaha added a commit that referenced this pull request Dec 13, 2017

Improve test suite (#394)
- [x] noSSL -> noTLS
- [x] LB type fails in AWS. Hitting CNAME does not connect the backend http server.
- [x] Ingress validator
- [x] Template renderer
- Test case: Run L7 ingress on non-standard ports
  - [x] HTTP on ports other than 80 & 443.
  - [x] 443: terminate SSL, 80: redirects to 443. (noSSL)
  - [x] HTTP (noSSL on port 443), application itself terminates SSL.
- Revise TCP secret name
  - [x] Test NoSSL to avoid TLS selectively.
  - [x] Test with matching TLS from `spec.TLS`
  - [x] Serve both HTTP and HTTPS under same host 
- Test case: Allow users to specify NodePort for service ports in NodePort mode. (TCP and HTTP)
  - [x] Initially set.
  - [x] Initially not set, then set via update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.