Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ingress-class #4

Merged
merged 6 commits into from Feb 1, 2017

Conversation

Projects
None yet
2 participants
@sadlil
Copy link
Contributor

commented Feb 1, 2017

Ingress class handled by voyager. Unset by default. Set to voyager to only handle ingress with annotation kubernetes.io/ingress-class=voyager.

@sadlil sadlil requested a review from tamalsaha Feb 1, 2017

@sadlil sadlil self-assigned this Feb 1, 2017

@sadlil sadlil added the enhancement label Feb 1, 2017

@@ -29,4 +30,6 @@ func (s *Config) AddFlags(fs *pflag.FlagSet) {
fs.StringVarP(&s.ProviderName, "cloud-provider", "c", s.ProviderName, "Name of cloud provider")
fs.StringVarP(&s.ClusterName, "cluster-name", "k", s.ClusterName, "Name of Kubernetes cluster")
fs.StringVarP(&s.LoadbalancerImageName, "haproxy-image", "h", s.LoadbalancerImageName, "haproxy image name to be run")

fs.StringVar(&s.IngressClass, "ingress-class", "", "ingress class this controller handles")

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Feb 1, 2017

Member

Ingress class handled by voyager. Unset by default. Set to voyager to only handle ingress with annotation kubernetes.io/ingress-class=voyager.

This comment has been minimized.

Copy link
@sadlil

sadlil Feb 1, 2017

Author Contributor

I didn't use StringVarP so, nno shorthand flag. Should I add shorthand?

@tamalsaha tamalsaha merged commit d7072bf into master Feb 1, 2017

@tamalsaha tamalsaha deleted the sadlil/ingress-class branch Feb 1, 2017

tamalsaha added a commit that referenced this pull request Apr 20, 2017

Squashed 'hack/libbuild/' changes from c32c249..9306596
9306596 Use $DOCKER_REGISTRY in build command
f2b13fe Load lib.sh from project specific files.
cf9de3a Introduce DOCKER_REGISTRY env variable (#4)
a512ccd Move project specific docker methods to their own files. (#3)
f46deb7 Add k8sdb & cowrypay scripts. (#2)
3313b96 Skip files for update_registry
ef11790 Add dot env for loading ENV vars (#1)
5837743 Add default list of deps
1e2eda3 Fix write_json.
7fb3825 Update README.md
765a9c7 Print message indicating current file/dir worked on.
97853a2 Fix fn name
06384a1 Add ungroup_go_imports
5d6aa3f Set version linker vars only if enabled.

git-subtree-dir: hack/libbuild
git-subtree-split: 93065964fda8023f8b8e36b47c1c087353f38af9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.