Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial voyager chart #43

Merged
merged 2 commits into from Apr 13, 2017

Conversation

Projects
None yet
2 participants
@saumanbiswas
Copy link
Contributor

commented Apr 4, 2017

No description provided.

@saumanbiswas saumanbiswas requested review from tamalsaha and sadlil Apr 4, 2017

spec:
containers:
- args:
- --cloud-provider=$CLOUD_PROVIDER

This comment has been minimized.

Copy link
@sadlil

sadlil Apr 4, 2017

Contributor

Why don't move those to values?

replicas: 1
selector:
matchLabels:
run: {{ template "fullname" . }}

This comment has been minimized.

Copy link
@sadlil

sadlil Apr 4, 2017

Contributor

Also add a svc.

@@ -0,0 +1,46 @@
# Voyager

This comment has been minimized.

Copy link
@sadlil

sadlil Apr 4, 2017

Contributor

Also add This file link in user guide. After the install and run process with title Run with helm.

## TL;DR;

```bash
$ helm install stable/voyager

This comment has been minimized.

Copy link
@sadlil

sadlil Apr 4, 2017

Contributor

Use real directory here. so that this command could run. When we move this to kubermetes/charts update there.

@sadlil

sadlil approved these changes Apr 4, 2017

Copy link
Contributor

left a comment

LGTM

@sadlil

sadlil approved these changes Apr 13, 2017

@sadlil sadlil merged commit 7c377e5 into master Apr 13, 2017

@sadlil sadlil deleted the voyager_chart branch Apr 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.