Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Session affinity to Backend service #460

Merged
merged 6 commits into from Sep 7, 2017

Conversation

Projects
None yet
2 participants
@sadlil
Copy link
Contributor

commented Sep 6, 2017

StickyIngress configures HAProxy to use sticky connection
to the backend servers.
Annotations could be applied to either Ingress or backend Service (since 3.2+).
ie: ingress.appscode.com/sticky-session: "true"
If applied to Ingress, all the backend connections would be sticky
If applied to Service and Ingress do not have this annotation only
connection to that backend service will be sticky.

Fixes #453

@sadlil sadlil added this to the 3.2.0 milestone Sep 6, 2017

@sadlil sadlil self-assigned this Sep 6, 2017

@@ -154,6 +152,11 @@ const (
certificateAnnotationKeyProviderCredentialSecretName = "certificate.appscode.com/provider-secret"
certificateAnnotationKeyACMEUserSecretName = "certificate.appscode.com/user-secret"
certificateAnnotationKeyACMEServerURL = "certificate.appscode.com/server-url"

// Sticky session configures proxy to use sticky connection

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Sep 6, 2017

Member

This description is incomplete. Make it clear how this works when applied to a Ingress vs applied to a Service. Also the example is incorrect when used in JSON.

ingress.appscode.com/sticky-session: "true"

This comment has been minimized.

Copy link
@sadlil

sadlil Sep 7, 2017

Author Contributor

could we apply this annotation in both? i have removed effects of applying this annotations in ingress. Should this be valid still?

@sadlil sadlil changed the title Restructure session affinity Apply Session affinity to Backend service Sep 7, 2017

@sadlil sadlil removed the breaking label Sep 7, 2017

tamalsaha added some commits Sep 7, 2017

Remove ShardInfo.Sticky.
Just use one Sticky variable in the template. Merge the Ingress and Service Sticky in Go code.

@tamalsaha tamalsaha merged commit e9aac41 into master Sep 7, 2017

@tamalsaha tamalsaha deleted the sticky-session branch Sep 7, 2017

tamalsaha added a commit that referenced this pull request Dec 13, 2017

Apply Session affinity to Backend service (#460)
StickyIngress configures HAProxy to use sticky connection
to the backend servers.
Annotations could  be applied to either Ingress or backend Service (since 3.2+).
ie: ingress.appscode.com/sticky-session: "true"
If applied to Ingress, all the backend connections would be sticky
If applied to Service and Ingress do not have this annotation only
connection to that backend service will be sticky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.