Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl passthrough support for annotations #501

Merged
merged 3 commits into from Sep 18, 2017

Conversation

Projects
None yet
2 participants
@sadlil
Copy link
Contributor

commented Sep 15, 2017

@sadlil sadlil added this to the 4.0.0 milestone Sep 15, 2017

@sadlil sadlil self-assigned this Sep 15, 2017

@sadlil sadlil requested a review from tamalsaha Sep 15, 2017

@tamalsaha tamalsaha requested a review from diptadas Sep 15, 2017

key.UsesSSL = true
if port := rule.HTTP.Port.IntValue(); port > 0 {
key.Port = port
} else {
key.Port = 443
}
} else if foundTLS && c.Ingress.SSLPassthrough() && !rule.HTTP.NoTLS {

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Sep 15, 2017

Member

Why FoundTLS has to be true if HAProxy is not offloading SSL ?

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Sep 15, 2017

@sadlil Why FoundTLS has to be true if HAProxy is not offloading SSL ?

@tamalsaha tamalsaha force-pushed the ssl-passthrough branch from defa93f to c1d4425 Sep 15, 2017

@tamalsaha tamalsaha merged commit 8db9c57 into master Sep 18, 2017

@tamalsaha tamalsaha deleted the ssl-passthrough branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.