Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SNI in TCP mode #805

Merged
merged 24 commits into from May 9, 2018

Conversation

Projects
None yet
3 participants
@tamalsaha
Copy link
Member

commented Jan 10, 2018

Fixes #751

@tamalsaha tamalsaha changed the title WIP: Support SNI mode in TCP WIP: Support SNI in TCP mode Jan 10, 2018

@tamalsaha tamalsaha force-pushed the tcp-sni branch from ec017ef to d677fc2 Jan 10, 2018

@tamalsaha tamalsaha requested a review from diptadas Jan 10, 2018

@tamalsaha tamalsaha force-pushed the tcp-sni branch 2 times, most recently from 33637c7 to b5d0dfb Feb 5, 2018

@tamalsaha tamalsaha force-pushed the master branch from 308a467 to 2764e55 Feb 28, 2018

@diptadas diptadas force-pushed the tcp-sni branch 7 times, most recently from bd0a361 to 2a12529 Apr 11, 2018

@diptadas diptadas force-pushed the tcp-sni branch 2 times, most recently from 5915f67 to a030878 Apr 24, 2018

@tamalsaha tamalsaha changed the title WIP: Support SNI in TCP mode Support SNI in TCP mode Apr 24, 2018

@diptadas diptadas force-pushed the tcp-sni branch 2 times, most recently from cadd74f to ed10801 Apr 25, 2018

@tamalsaha tamalsaha force-pushed the tcp-sni branch from bdecd31 to dfdb5b7 May 3, 2018

@tamalsaha tamalsaha force-pushed the tcp-sni branch from dfdb5b7 to 396771c May 3, 2018

@diptadas diptadas changed the title Support SNI in TCP mode WIP: Support SNI in TCP mode May 3, 2018

@codecov-io

This comment has been minimized.

Copy link

commented May 4, 2018

Codecov Report

Merging #805 into master will increase coverage by 0.23%.
The diff coverage is 28.79%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #805      +/-   ##
=========================================
+ Coverage     3.5%   3.73%   +0.23%     
=========================================
  Files          52      52              
  Lines       18203   18216      +13     
=========================================
+ Hits          638     681      +43     
+ Misses      17443   17408      -35     
- Partials      122     127       +5
Impacted Files Coverage Δ
pkg/ingress/parser.go 3.57% <0%> (-0.32%) ⬇️
pkg/haproxy/template/template.go 57.35% <100%> (+6.5%) ⬆️
pkg/haproxy/api/types.go 14.28% <100%> (ø) ⬆️
apis/voyager/v1beta1/diff.go 18.18% <100%> (+3.31%) ⬆️
pkg/haproxy/api/helper.go 17.12% <13.04%> (-0.14%) ⬇️
apis/voyager/v1beta1/validator.go 51.21% <59.01%> (+3.97%) ⬆️
apis/voyager/v1beta1/annotations.go 28.67% <0%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d1266...825849e. Read the comment docs.

@diptadas diptadas force-pushed the tcp-sni branch from c504e8b to f2ac926 May 7, 2018

@diptadas diptadas changed the title WIP: Support SNI in TCP mode Support SNI in TCP mode May 7, 2018

@diptadas diptadas force-pushed the tcp-sni branch 2 times, most recently from 374da0a to 825849e May 8, 2018

@diptadas diptadas force-pushed the tcp-sni branch from 825849e to cd75394 May 9, 2018

diptadas added some commits May 9, 2018

diptadas
diptadas
diptadas
diptadas
diptadas

@diptadas diptadas force-pushed the tcp-sni branch from 4098980 to 0e45f55 May 9, 2018

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented May 9, 2018

/LGTM

@tamalsaha tamalsaha merged commit e18f3fe into master May 9, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the tcp-sni branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.