Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HAProxy 1.8.7 #806

Merged
merged 11 commits into from Apr 21, 2018

Conversation

Projects
None yet
5 participants
@tamalsaha
Copy link
Member

commented Jan 11, 2018

#647

@tamalsaha tamalsaha requested a review from diptadas Jan 11, 2018

@tamalsaha tamalsaha force-pushed the hp183 branch 7 times, most recently from 0743ce4 to 5d6dc8d Jan 11, 2018

@tamalsaha tamalsaha force-pushed the hp183 branch 3 times, most recently from f8b3a6b to 40c63d2 Jan 19, 2018

@tamalsaha tamalsaha changed the title Add HAProxy 1.8.3 WIP: Add HAProxy 1.8.3 Feb 5, 2018

@george-oakling

This comment has been minimized.

Copy link

commented Feb 13, 2018

Personally, I wouldnt use Haproxy 1.8.3 as it has some problems with Firefox using alpn h2. The newer version will have the issue fixed.

@tamalsaha tamalsaha force-pushed the master branch from 308a467 to 2764e55 Feb 28, 2018

@diptadas diptadas force-pushed the hp183 branch from 02703e1 to a9643a3 Mar 19, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Mar 19, 2018

Codecov Report

Merging #806 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #806      +/-   ##
=========================================
+ Coverage    3.52%   3.52%   +<.01%     
=========================================
  Files          51      51              
  Lines       17916   17912       -4     
=========================================
  Hits          632     632              
+ Misses      17157   17153       -4     
  Partials      127     127
Impacted Files Coverage Δ
pkg/ingress/internal.go 0% <ø> (ø) ⬆️
pkg/ingress/loadbalancer.go 1.86% <ø> (ø) ⬆️
pkg/ingress/hostport.go 2.85% <ø> (ø) ⬆️
pkg/ingress/nodeport.go 1.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d147a39...bb84933. Read the comment docs.

@tamalsaha tamalsaha changed the title WIP: Add HAProxy 1.8.3 WIP: Add HAProxy 1.8.4 Mar 19, 2018

@diptadas diptadas force-pushed the hp183 branch 2 times, most recently from 0149871 to 735fc2b Mar 23, 2018

@tamalsaha tamalsaha changed the title WIP: Add HAProxy 1.8.4 WIP: Add HAProxy 1.8.5 Mar 27, 2018

@tamalsaha tamalsaha changed the title WIP: Add HAProxy 1.8.5 Use HAProxy 1.8.5 Mar 27, 2018

@diptadas diptadas force-pushed the hp183 branch from fe9148e to d870d8c Mar 28, 2018

@shaneog

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2018

Is there a milestone for this PR? It would be great to have it merged :)

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2018

@shaneog, All our e2e test are passing. We want to get this and #954 done (which needs this one). There are no known blockers. So, I am hopeful that we get there soon.

@diptadas diptadas force-pushed the hp183 branch from 4088e8e to d0863a3 Apr 6, 2018

diptadas
diptadas

@tamalsaha tamalsaha changed the title Use HAProxy 1.8.5 Use HAProxy 1.8.7 Apr 21, 2018

tamalsaha added some commits Apr 21, 2018

@tamalsaha tamalsaha merged commit 107aa1b into master Apr 21, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the hp183 branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.