Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external-auth/oauth #954

Merged
merged 8 commits into from Apr 24, 2018

Conversation

Projects
None yet
3 participants
@diptadas
Copy link
Contributor

commented Mar 29, 2018

No description provided.

@diptadas diptadas requested a review from tamalsaha Mar 29, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Mar 29, 2018

Codecov Report

Merging #954 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #954      +/-   ##
=========================================
- Coverage    3.53%   3.51%   -0.02%     
=========================================
  Files          51      51              
  Lines       17949   18034      +85     
=========================================
  Hits          634     634              
- Misses      17185   17270      +85     
  Partials      130     130
Impacted Files Coverage Δ
pkg/haproxy/api/types.go 18.18% <ø> (ø) ⬆️
apis/voyager/v1beta1/zz_generated.deepcopy.go 0% <0%> (ø) ⬆️
apis/voyager/v1beta1/openapi_generated.go 0% <0%> (ø) ⬆️
pkg/ingress/parser.go 3.86% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbc9c6...477cbd3. Read the comment docs.

@tamalsaha tamalsaha referenced this pull request Mar 30, 2018

Merged

Use HAProxy 1.8.7 #806

@tamalsaha tamalsaha changed the base branch from master to hp183 Apr 5, 2018

@diptadas diptadas force-pushed the oauth branch from 9762a4c to 96189b5 Apr 6, 2018

@diptadas diptadas force-pushed the hp183 branch from 4088e8e to d0863a3 Apr 6, 2018

@diptadas diptadas changed the base branch from hp183 to master Apr 6, 2018

@diptadas diptadas force-pushed the oauth branch 2 times, most recently from db78181 to 0b5dfde Apr 6, 2018

@diptadas diptadas changed the base branch from master to hp183 Apr 6, 2018

@diptadas diptadas changed the title WIP: add support for external-auth/oauth Add support for external-auth/oauth Apr 6, 2018

@diptadas diptadas force-pushed the oauth branch from bfec22f to d52f3d7 Apr 23, 2018

@diptadas diptadas changed the base branch from hp183 to master Apr 23, 2018

@diptadas diptadas force-pushed the oauth branch from 616dc27 to 392c4e7 Apr 23, 2018

value: ...
- name: OAUTH2_PROXY_COOKIE_SECRET
value: Y/XCgwGzcE/BIkhTtXFcSQ==
image: docker.io/colemickens/oauth2_proxy:latest

This comment has been minimized.

Copy link
@tamalsaha

tamalsaha Apr 24, 2018

Member

Use our docker image or official docker image.

diptadas

@tamalsaha tamalsaha merged commit 9cd7689 into master Apr 24, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the oauth branch Apr 24, 2018

tamalsaha added a commit that referenced this pull request May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.