Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to Akamai FastDNS provider for certificates #965

Merged
merged 2 commits into from Apr 5, 2018

Conversation

@jeffersongirao
Copy link
Contributor

commented Apr 3, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 3, 2018

Codecov Report

Merging #965 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #965   +/-   ##
======================================
  Coverage    8.04%   8.04%           
======================================
  Files          50      50           
  Lines        7731    7731           
======================================
  Hits          622     622           
  Misses       6983    6983           
  Partials      126     126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3416885...b1addac. Read the comment docs.

})

AfterEach(func() {
if options.Cleanup {

This comment has been minimized.

Copy link
@diptadas

diptadas Apr 5, 2018

Contributor

Cleanup certificate object

f.Certificate.Delete(cert)

This comment has been minimized.

Copy link
@jeffersongirao

jeffersongirao Apr 5, 2018

Author Contributor

Good catch @diptadas! It is fixed now. Thanks!

@jeffersongirao

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

@diptadas @tamalsaha Could you please re-trigger the build? Checking the logs in Travis it seems like it succeeded one and didn't start the other. Thanks in advance!

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Triggered build. Btw, @jeffersongirao , you should be able to do that from the Travis ci webpage yourself for your prs. https://travis-ci.org/appscode/voyager

@jeffersongirao

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

@tamalsaha Thanks, I've just noticed that I was not logged in Travis, that is why the option didn't show up 🤣 shame on me :)

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Have you tried using your custom docker image to test this e2e? The installer script options are described here: https://github.com/appscode/voyager/blob/master/docs/setup/install.md#customizing-installer

@jeffersongirao

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

@tamalsaha not yet, I will give it a shot. Thanks.

@jeffersongirao

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

@tamalsaha Just tried in one of our clusters and it worked good.

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Great! I am going to take a look soon. Can you squash your commits and rebase it on master?

jeffersongirao and others added 2 commits Apr 5, 2018

@tamalsaha tamalsaha merged commit 843e6f6 into appscode:master Apr 5, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Thanks @jeffersongirao !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.