Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL redirect for LB type NodePort #968

Merged
merged 7 commits into from Apr 23, 2018

Conversation

Projects
None yet
4 participants

@diptadas diptadas requested a review from tamalsaha Apr 4, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Apr 4, 2018

Codecov Report

Merging #968 into master will increase coverage by <.01%.
The diff coverage is 5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #968      +/-   ##
=========================================
+ Coverage    3.52%   3.53%   +<.01%     
=========================================
  Files          51      51              
  Lines       17912   17936      +24     
=========================================
+ Hits          632     634       +2     
- Misses      17153   17172      +19     
- Partials      127     130       +3
Impacted Files Coverage Δ
pkg/haproxy/api/types.go 18.18% <ø> (ø) ⬆️
pkg/ingress/nodeport.go 1.74% <0%> (-0.04%) ⬇️
pkg/ingress/parser.go 3.91% <0%> (-0.04%) ⬇️
pkg/haproxy/template/template.go 50.84% <27.27%> (-4.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 107aa1b...a442aac. Read the comment docs.

@diptadas diptadas force-pushed the fix-nodeport branch 4 times, most recently from 53e2d37 to 32076f3 Apr 5, 2018

@diptadas diptadas changed the title WIP: Fix SSL redirect for LB type NodePort Fix SSL redirect for LB type NodePort Apr 6, 2018

@diptadas diptadas force-pushed the fix-nodeport branch from 1e5ab59 to 88f940e Apr 12, 2018

@tamalsaha tamalsaha force-pushed the fix-nodeport branch from 88f940e to 074595b Apr 21, 2018

tamalsaha added some commits Apr 21, 2018

@tamalsaha tamalsaha force-pushed the fix-nodeport branch from b92cc0c to d09a8e7 Apr 23, 2018

@tamalsaha tamalsaha force-pushed the fix-nodeport branch from d09a8e7 to 7e7bf6c Apr 23, 2018

@tamalsaha tamalsaha force-pushed the fix-nodeport branch from b8347eb to 8f82822 Apr 23, 2018

@tamalsaha tamalsaha merged commit 47881b4 into master Apr 23, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the fix-nodeport branch Apr 23, 2018

@mouhsinelonly

This comment has been minimized.

Copy link

commented Feb 25, 2019

Is this merged , because i cant get ssl-redirect to work

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Yes. Please open a new issue with Ingress yaml and the what you expect to see and what you see. Also, what version of Voyager you are using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.