Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#970 Added metallb as a cloud provider option #972

Merged
merged 3 commits into from Apr 5, 2018

Conversation

Projects
None yet
3 participants
@schubter
Copy link
Contributor

commented Apr 5, 2018

i've applied a newly built haproxy image to the crash looping deployment and changed the args to -cloudprovider=metallb and the pod started up successfully.
running curl against the assigned LB-IP produced a 503 and a proper log in the container

local0.info: Apr 5 12:18:35 haproxy[30]: 10.40.0.0:63780 [05/Apr/2018:12:18:35.428] http-0_0_0_0-80 http-0_0_0_0-80/<NOSRV> -1/-1/-1/-1/1 503 212 - - SC-- 0/0/0/0/0 0/0 "GET / HTTP/1.1"

schubter added some commits Apr 5, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Apr 5, 2018

Codecov Report

Merging #972 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #972      +/-   ##
=========================================
+ Coverage    8.03%   8.04%   +0.01%     
=========================================
  Files          50      50              
  Lines        7730    7731       +1     
=========================================
+ Hits          621     622       +1     
  Misses       6983    6983              
  Partials      126     126
Impacted Files Coverage Δ
apis/voyager/v1beta1/validator.go 45.66% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea143e9...f656c03. Read the comment docs.

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

running curl against the assigned LB-IP produced a 503

Are you expecting that to be 503?

@schubter

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

yeah, it was a newly deployed ingress with a backend that was not up

@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Did it work after you added back end?

@schubter

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2018

@tamalsaha tamalsaha merged commit 3416885 into appscode:master Apr 5, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@tamalsaha

This comment has been minimized.

Copy link
Member

commented Apr 5, 2018

Thanks @schubter !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.