Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace to relevant kubernetes resources #985

Merged
merged 4 commits into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@Rigdon
Copy link
Contributor

commented Apr 17, 2018

Fixes #984

I did a basic installation with this and everything seems ok at first glance. Someone a bit more familiar with the interaction of these pieces should take a look though (especially whether the admission webhook still works)

M. Ryan Rigdon
@codecov-io

This comment has been minimized.

Copy link

commented Apr 17, 2018

Codecov Report

Merging #985 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #985   +/-   ##
======================================
  Coverage    3.52%   3.52%           
======================================
  Files          51      51           
  Lines       17916   17916           
======================================
  Hits          632     632           
  Misses      17157   17157           
  Partials      127     127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a0006...01aaccc. Read the comment docs.

tamalsaha added some commits Apr 18, 2018

@tamalsaha tamalsaha changed the title add namespace to relevant kubernetes resources Add namespace to relevant kubernetes resources Apr 18, 2018

@tamalsaha
Copy link
Member

left a comment

I removed namespace from non-namespaced objects (ClusterRole, ValidatingWebhookConfiguration)

@tamalsaha tamalsaha merged commit 726383a into appscode:master Apr 18, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@Rigdon Rigdon deleted the Rigdon:helm-add-namespace branch Apr 18, 2018

@Rigdon

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2018

Thanks for the updates @tamalsaha. I was afraid I went too far with them but the K8s docs don't make it entirely clear which objects aren't namespaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.