Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue wildcard certs using LE ACME v2 #996

Merged
merged 2 commits into from Apr 30, 2018

Conversation

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented Apr 24, 2018

Fixes #185
Fixes #994

@tamalsaha tamalsaha requested a review from diptadas Apr 24, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Apr 24, 2018

Codecov Report

Merging #996 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #996   +/-   ##
======================================
  Coverage    3.54%   3.54%           
======================================
  Files          52      52           
  Lines       18005   18005           
======================================
  Hits          638     638           
  Misses      17245   17245           
  Partials      122     122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9e749...534113f. Read the comment docs.

@tamalsaha tamalsaha force-pushed the acmev2 branch 3 times, most recently from 79ad3d4 to 101827b Apr 24, 2018

@tamalsaha tamalsaha force-pushed the acmev2 branch from 101827b to 39b9095 Apr 30, 2018

@tamalsaha

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2018

I have manually tested in a GKE cluster for 2 scenarios:

  • just a wildcard certificate : *.example.com . It worked on first try.
  • A SANS certificate: - abc.example.com, www.example.com . This case had some initial errors related to authorization. But it worked on its own after 3-4 minutes.

@tamalsaha tamalsaha merged commit 166ef6e into master Apr 30, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the acmev2 branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.