Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated validator for merging empty-host with wildcard-host #998

Merged
merged 5 commits into from Apr 25, 2018

Conversation

Projects
None yet
3 participants
@diptadas
Copy link
Contributor

commented Apr 25, 2018

  • GetHost() is moved to API and used in validator to check path conflicts
  • In parser.go, GetHost() is done only when extracting data from rule.Host, in other cases we don't need it, since they are populated from rule.Host
  • If TLS is defined for * host and we try to merge empty-host with * host, it will cause conflicting TLS error, is it OK ?

diptadas added some commits Apr 25, 2018

@diptadas diptadas requested a review from tamalsaha Apr 25, 2018

diptadas
@codecov-io

This comment has been minimized.

Copy link

commented Apr 25, 2018

Codecov Report

Merging #998 into master will increase coverage by 0.04%.
The diff coverage is 43.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #998      +/-   ##
=========================================
+ Coverage    3.51%   3.56%   +0.04%     
=========================================
  Files          51      51              
  Lines       18034   18034              
=========================================
+ Hits          634     643       +9     
+ Misses      17270   17263       -7     
+ Partials      130     128       -2
Impacted Files Coverage Δ
pkg/ingress/parser.go 3.89% <0%> (+0.02%) ⬆️
apis/voyager/v1beta1/diff.go 14.86% <100%> (+2.97%) ⬆️
apis/voyager/v1beta1/validator.go 47.24% <100%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74feaf...3dd3f44. Read the comment docs.

@tamalsaha tamalsaha merged commit a53bad1 into master Apr 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tamalsaha tamalsaha deleted the fix-host branch Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.