Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both Deployment and DaemonSet to run HAProxy pods #999

Merged
merged 6 commits into from Apr 30, 2018

Conversation

Projects
None yet
2 participants
@tamalsaha
Copy link
Member

commented Apr 25, 2018

Fixes #897

If you want to use DaemonSet to run HAProxy pods, apply the following annotation to Ingress

ingress.appscode.com/workload-kind: DaemonSet

@tamalsaha tamalsaha requested a review from diptadas Apr 25, 2018

@tamalsaha tamalsaha force-pushed the dm branch 3 times, most recently from 022f7fe to 4dc6ea9 Apr 25, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Apr 25, 2018

Codecov Report

Merging #999 into master will decrease coverage by 0.02%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #999      +/-   ##
=========================================
- Coverage    3.56%   3.54%   -0.03%     
=========================================
  Files          51      52       +1     
  Lines       18034   18005      -29     
=========================================
- Hits          643     638       -5     
+ Misses      17263   17245      -18     
+ Partials      128     122       -6
Impacted Files Coverage Δ
pkg/operator/operator.go 0% <ø> (ø) ⬆️
pkg/ingress/delete.go 0% <ø> (ø) ⬆️
pkg/operator/deployments.go 0% <0%> (ø) ⬆️
pkg/ingress/nodeport.go 0% <0%> (-1.74%) ⬇️
pkg/operator/daemonsets.go 0% <0%> (ø)
pkg/ingress/internal.go 0% <0%> (ø) ⬆️
pkg/operator/config.go 0% <0%> (ø) ⬆️
pkg/operator/ingresses.go 0% <0%> (ø) ⬆️
pkg/ingress/loadbalancer.go 0% <0%> (-1.86%) ⬇️
pkg/operator/ingress_crds.go 0% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309e591...e9d41c3. Read the comment docs.

@tamalsaha tamalsaha force-pushed the dm branch 5 times, most recently from ff03476 to 3d9c19a Apr 25, 2018

tamalsaha added some commits Apr 30, 2018

@tamalsaha tamalsaha merged commit d7cd100 into master Apr 30, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tamalsaha tamalsaha deleted the dm branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.