New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove interface usage from types package for Node #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsc
approved these changes
Oct 1, 2021
luismiramirez
force-pushed
the
remove-types-package-dependency
branch
6 times, most recently
from
October 4, 2021 13:43
2049166
to
d8804a4
Compare
This comment has been minimized.
This comment has been minimized.
tombruijn
requested changes
Oct 5, 2021
tombruijn
reviewed
Oct 5, 2021
This comment has been minimized.
This comment has been minimized.
All Node.js specific interfaces from the types package are now defined inside nodejs core package. There's still a dependency from types package for common types as `Func`, `HashMap`, and `HasMapValue`. With this change we keep taking advantage of interfaces but now they're defined in a place where they're used.
luismiramirez
force-pushed
the
remove-types-package-dependency
branch
from
October 6, 2021 07:45
d8804a4
to
9c8319e
Compare
While performing the daily checks some issues were found with this Pull Request.
|
jeffkreeftmeijer
approved these changes
Oct 7, 2021
tombruijn
approved these changes
Oct 8, 2021
tombruijn
added a commit
that referenced
this pull request
Feb 1, 2022
We changed the types used in PR #451. We no longer rely on the `@appsignal/types` package for this, but define it in the package itself. The ScopeManager appears to not have been updated to match and is the only place in which the `NodeSpan` from the types package is still used. If we update this usage we can remove all Node.js types from the types package.
tombruijn
added a commit
that referenced
this pull request
Feb 1, 2022
We changed the types used in PR #451. We no longer rely on the `@appsignal/types` package for this, but define it in the package itself. The ScopeManager appears to not have been updated to match and is the only place in which the `NodeSpan` from the types package is still used. If we update this usage we can remove all Node.js types from the types package.
tombruijn
added a commit
to appsignal/appsignal-javascript
that referenced
this pull request
Feb 3, 2022
We moved all types to the Node.js package in PRs: - appsignal/appsignal-nodejs#451 - appsignal/appsignal-nodejs#587 Let's remove them from the types package to avoid confusion. People can instead use the types/interfaces the Node.js package exports if need.
tombruijn
added a commit
to appsignal/appsignal-javascript
that referenced
this pull request
Feb 3, 2022
We moved all types to the Node.js package in PRs: - appsignal/appsignal-nodejs#451 - appsignal/appsignal-nodejs#587 Let's remove them from the types package to avoid confusion. People can instead use the types/interfaces the Node.js package exports if need.
tombruijn
added a commit
to appsignal/appsignal-javascript
that referenced
this pull request
Feb 3, 2022
We moved all types to the Node.js package in PRs: - appsignal/appsignal-nodejs#451 - appsignal/appsignal-nodejs#587 Let's remove them from the types package to avoid confusion. People can instead use the types/interfaces the Node.js package exports if need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove interface usage from types package for Node
All Node.js-specific interfaces from the types package are now defined
inside the nodejs core package. There's still a dependency from types
package for common types as
Func
,HashMap
, andHasMapValue
.With this change, we keep taking advantage of interfaces, but now they're
defined in a place where they're used.