No longer gzip request bodies send by transmitter #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsimitsu
approved these changes
Mar 22, 2017
There's no more need to gzip everything we send to our servers. We use it in so few requests it's hardly worth the effort. We only use the transmitter for the Push API key validation, which has no body, and the marker transmitter which is not used frequently and no longer the recommended method to create markers. The marker transmitter, used by `appsignal notify_of_deploy`, which is a method of creating deploy markers which is no longer the recommended way to do so. Instead use the `APP_REVISION` environment variable. See also: http://docs.appsignal.com/application/markers/deploy-markers.html
thijsc
approved these changes
Mar 22, 2017
|
Tested with a not-compressed (non-gzip) request body, the following requests to the AppSignal Push API and it all seems to work still :)
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no more need to gzip everything we send to our servers. We use
it in so few requests it's hardly worth the effort. We only use the
transmitter for the Push API key validation, which has no body, and the
marker transmitter which is not used frequently and no longer the
recommended method to create markers.
The marker transmitter, used by
appsignal notify_of_deploy, which is amethod of creating deploy markers which is no longer the recommended way
to do so. Instead use the
APP_REVISIONenvironment variable. See also:http://docs.appsignal.com/application/markers/deploy-markers.html