Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queue time on DelayedJob integration #297

Merged
merged 1 commit into from May 26, 2017

Conversation

@tombruijn
Copy link
Member

commented May 24, 2017

Would use created_at, which is the time the job was created. This is
not necessarily when it was meant for the queue. Yes, it is enqueued in
the sense that it is registered in the job queue list, but it's only
meant to actually be enqueued in the DelayedJob worker at the time
specified in run_at.

This change uses the run_at as the queue start time so that jobs that
are scheduled to run a long time from now don't add the time from the
moment the job was created until it was actually run as the queue time.

Fixes #296

Fix queue time on DelayedJob integration
Would use `created_at`, which is the time the job was created. This is
not necessarily when it was meant for the queue. Yes, it is enqueued in
the sense that it is registered in the job queue list, but it's only
meant to actually be enqueued in the DelayedJob worker at the time
specified in `run_at`.

This change uses the run_at as the queue start time so that jobs that
are scheduled to run a long time from now don't add the time from the
moment the job was created until it was actually run as the queue time.

@tombruijn tombruijn requested review from thijsc and jeffkreeftmeijer May 24, 2017

@thijsc

thijsc approved these changes May 26, 2017

@tombruijn tombruijn merged commit 63b9eb5 into master May 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tombruijn tombruijn deleted the delayed_job_run_at branch May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.