Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix: Add hotfix for Snowflake plugin driver (#19876)
*  Updated the snowflake jdbc version from 3.13.25 to 3.13.26
* Added a new property "jdbc_query_result_format" with value as json in order to fix an issue where queries were returning empty results when executed through Appsmith (#19784)

_Originally posted by @what-the-diff[bot] in #19876 (comment)
  • Loading branch information
mohanarpit committed Jan 18, 2023
2 parents d009c24 + 0fd5404 commit d943900
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 33 deletions.
34 changes: 1 addition & 33 deletions app/server/appsmith-plugins/snowflakePlugin/pom.xml
Expand Up @@ -24,42 +24,10 @@
</properties>

<dependencies>

<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-core</artifactId>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-web</artifactId>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-webflux</artifactId>
<exclusions>
<exclusion>
<groupId>io.projectreactor</groupId>
<artifactId>reactor-core</artifactId>
</exclusion>
<exclusion>
<groupId>org.springframework</groupId>
<artifactId>spring-core</artifactId>
</exclusion>
<exclusion>
<groupId>org.springframework</groupId>
<artifactId>spring-web</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>net.snowflake</groupId>
<artifactId>snowflake-jdbc</artifactId>
<version>3.13.25</version>
<version>3.13.26</version>
</dependency>

<dependency>
Expand Down
Expand Up @@ -98,6 +98,8 @@ public Mono<Connection> datasourceCreate(DatasourceConfiguration datasourceConfi
properties.setProperty("db", String.valueOf(datasourceConfiguration.getProperties().get(1).getValue()));
properties.setProperty("schema", String.valueOf(datasourceConfiguration.getProperties().get(2).getValue()));
properties.setProperty("role", String.valueOf(datasourceConfiguration.getProperties().get(3).getValue()));
/* Ref: https://github.com/appsmithorg/appsmith/issues/19784 */
properties.setProperty("jdbc_query_result_format", "json");

return Mono
.fromCallable(() -> {
Expand Down

0 comments on commit d943900

Please sign in to comment.