Skip to content

[Feature]: Oracle intgeration: add core query execution flow #21274

Closed
#21273
Closed
[Feature]: Oracle intgeration: add core query execution flow#21274
#21273
Assignees
sumitsum
Labels
EnhancementNew feature or requestIntegrations ProductIssues related to a specific integrationOracle SQL DBIssues related to the Oracle pluginQuery & JS PodIssues related to the query & JS Pod

Description

@sumitsum
sumitsum
opened on Mar 8, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Summary

add core query execution flow for the Oracle plugin

Why should this be worked on?

add core query execution flow

How to test

(1) Create Oracle DS using the credentials provided on Notion
(2) Test that the datasource test passes for valid creds and fails for invalid creds
(3) Save the datasource
(4) create a new query on datsource
(5) Run a sample query on datasource eg.

SELECT *
FROM 
    user_tab_cols
ORDER BY 
    table_name, 
    column_id

Activity

  1. sumitsum
    added
    EnhancementNew feature or request
    Oracle SQL DBIssues related to the Oracle plugin
    on Mar 8, 2023
  2. sumitsum
    self-assigned this
    on Mar 8, 2023
  3. github-actions
    added
    Integrations ProductIssues related to a specific integration
    on Mar 8, 2023

  4. btsgh commented on Mar 16, 2023

    @btsgh
    btsgh
    on Mar 16, 2023
    Collaborator

    A few observations - @sumitsum - while running the above mentioned tests -

    1. Schema not available on the Entity Explorer for Oracle DS.
    2. If I use admin user with blank password, the test passes.
    3. Database name field should be shown as required field, since, if we leave it blank, it throws an error to the effect - missing database name.
    4. This message is not seen on the Edit DS page. - Whitelist the IP 18.223.74.85 and 3.131.104.27 on your database instance to connect to it. Learn more
    5. The Oracle logo image seems a little off - with some whitebackground - this is not consistent with the other logos

  5. sumitsum commented on Mar 16, 2023

    @sumitsum
    sumitsum
    on Mar 16, 2023
    ContributorAuthor

    @btsgh thanks,
    (1) This is to be picked up later as mentioned in the PR description.
    (2), (3) - thanks for catching this - I will try to address it in the next PR. Since these are minor issues we may move forward with current PR as we are merging changes under a feature flag right now.
    (4) Not sure how to address this . Will check with FE folks and try to address this on one of the next PRs.
    (5) Will try to update the logo in one of the next PRs.

  6. sumitsum
    closed this as completedin #21273on Mar 16, 2023
  7. Nikhil-Nandagopal
    added
    Query & JS PodIssues related to the query & JS Pod
    on Aug 6, 2024
  8. rajatagrawal
    added a parent issue on Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EnhancementNew feature or requestIntegrations ProductIssues related to a specific integrationOracle SQL DBIssues related to the Oracle pluginQuery & JS PodIssues related to the query & JS Pod

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions