Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding a check for invalid hosts on redirects as well #15782

Merged
merged 1 commit into from Aug 6, 2022

Conversation

mohanarpit
Copy link
Member

Description

Fixes issue for checking for invalid hosts even when there are redirects in the Rest API plugin.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Junit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Aug 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
appsmith ⬜️ Ignored (Inspect) Aug 6, 2022 at 6:42AM (UTC)

@sharat87 sharat87 changed the title Adding a check for invalid hosts on redirects as well fix: Adding a check for invalid hosts on redirects as well Aug 6, 2022
@mohanarpit mohanarpit added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Aug 6, 2022
@github-actions github-actions bot added the Bug Something isn't working label Aug 6, 2022
@mohanarpit mohanarpit merged commit 0967b51 into release Aug 6, 2022
@mohanarpit mohanarpit deleted the fix/restapi-invalid-host-redirect branch August 6, 2022 07:06
sharat87 pushed a commit that referenced this pull request Aug 8, 2022
## Description

Fixes issue for checking for invalid hosts even when there are redirects in the Rest API plugin.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Junit test

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

(cherry picked from commit 0967b51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants