Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code commenting #9369 #18667

Merged
merged 37 commits into from Jan 6, 2023
Merged

feat: code commenting #9369 #18667

merged 37 commits into from Jan 6, 2023

Conversation

ravikp7
Copy link
Contributor

@ravikp7 ravikp7 commented Dec 5, 2022

Description

Adds code commenting in JS objects code editor and JS fields. Users can use Cmd + / on Mac and Ctrl + / on other systems to comment/uncomment code now.

Fixes #9369

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual
  • Jest

Test Plan

Issues raised during DP testing

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@vercel
Copy link

vercel bot commented Dec 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 8:36AM (UTC)

@github-actions github-actions bot added Enhancement New feature or request FE Coders Pod Issues related to users writing javascript in appsmith JS Objects Issues related to JS Objects JS Usability usability issues with JS editor and JS elsewhere Low effort Takes 1-2 days and removed Enhancement New feature or request labels Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added Enhancement New feature or request and removed Enhancement New feature or request labels Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Unable to find test scripts. Please add necessary tests to the PR.

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added Enhancement New feature or request and removed Enhancement New feature or request labels Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Unable to find test scripts. Please add necessary tests to the PR.

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added Enhancement New feature or request and removed Enhancement New feature or request labels Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added the Enhancement New feature or request label Dec 5, 2022
@github-actions github-actions bot removed the Enhancement New feature or request label Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FormProperties_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Text_wrapping_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Text_wrapping_spec.js

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FormProperties_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Text_wrapping_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Text_wrapping_spec.js

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FormProperties_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Text_wrapping_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/Text_wrapping_spec.js

@ravikp7
Copy link
Contributor Author

ravikp7 commented Jan 5, 2023

/ok-to-test sha=994350755eb7281653062fed5dc6eed00aabc923

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3843906970.
Workflow: Appsmith External Integration Test Workflow.
Commit: 994350755eb7281653062fed5dc6eed00aabc923.
PR: 18667.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18667&runId=3843906970_1

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js

@ravikp7
Copy link
Contributor Author

ravikp7 commented Jan 5, 2023

/ok-to-test sha=943ebfd60b255f8be0ec1102656ab7258c516af6

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3848224585.
Workflow: Appsmith External Integration Test Workflow.
Commit: 943ebfd60b255f8be0ec1102656ab7258c516af6.
PR: 18667.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18667&runId=3848224585_1

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RepoLimitExceededErrorModal_spec.js

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

The following are new failures, please fix them before merging the PR

rimildeyjsr
rimildeyjsr previously approved these changes Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts

@ravikp7
Copy link
Contributor Author

ravikp7 commented Jan 6, 2023

/ok-to-test sha=6b6b26eed7d2342beecb724080e2eb2c3d716bef

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3853810958.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6b6b26eed7d2342beecb724080e2eb2c3d716bef.
PR: 18667.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18667&runId=3853810958_1

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad_cyclic_dependency_errors_spec.js

@ravikp7 ravikp7 enabled auto-merge (squash) January 6, 2023 09:54
@ravikp7 ravikp7 merged commit fa93083 into release Jan 6, 2023
@ravikp7 ravikp7 deleted the feat/code-commenting branch January 6, 2023 11:57
keyurparalkar pushed a commit that referenced this pull request Jan 9, 2023
## Description
Adds code commenting in JS objects code editor and JS fields. Users can
use `Cmd + /` on Mac and `Ctrl + /` on other systems to
comment/uncomment code now.

Fixes #9369



## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?
- Manual
- Jest

### Test Plan
- [x] https://github.com/appsmithorg/TestSmith/issues/2120
- [x] https://github.com/appsmithorg/TestSmith/issues/2121
- [x] https://github.com/appsmithorg/TestSmith/issues/2122

### Issues raised during DP testing
- [ ]
#18667 (comment)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request FE Coders Pod Issues related to users writing javascript in appsmith JS Objects Issues related to JS Objects JS Usability usability issues with JS editor and JS elsewhere Low effort Takes 1-2 days Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Ctrl + / shortcut for comments in JS Editor
6 participants