New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: code commenting #9369 #18667
feat: code commenting #9369 #18667
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Unable to find test scripts. Please add necessary tests to the PR. |
Unable to find test scripts. Please add necessary tests to the PR. |
1 similar comment
Unable to find test scripts. Please add necessary tests to the PR. |
Unable to find test scripts. Please add necessary tests to the PR. |
1 similar comment
Unable to find test scripts. Please add necessary tests to the PR. |
Unable to find test scripts. Please add necessary tests to the PR. |
Unable to find test scripts. Please add necessary tests to the PR. |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
1 similar comment
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
/ok-to-test sha=994350755eb7281653062fed5dc6eed00aabc923 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3843906970. |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
/ok-to-test sha=943ebfd60b255f8be0ec1102656ab7258c516af6 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3848224585. |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RepoLimitExceededErrorModal_spec.js |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts |
The following are new failures, please fix them before merging the PR |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite_Fat/ClientSideTests/Refactoring/Refactoring_spec.ts |
/ok-to-test sha=6b6b26eed7d2342beecb724080e2eb2c3d716bef |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3853810958. |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
## Description Adds code commenting in JS objects code editor and JS fields. Users can use `Cmd + /` on Mac and `Ctrl + /` on other systems to comment/uncomment code now. Fixes #9369 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual - Jest ### Test Plan - [x] https://github.com/appsmithorg/TestSmith/issues/2120 - [x] https://github.com/appsmithorg/TestSmith/issues/2121 - [x] https://github.com/appsmithorg/TestSmith/issues/2122 ### Issues raised during DP testing - [ ] #18667 (comment) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Description
Adds code commenting in JS objects code editor and JS fields. Users can use
Cmd + /
on Mac andCtrl + /
on other systems to comment/uncomment code now.Fixes #9369
Type of change
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity: