New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Date column type editing for table widget #19181
feat: Date column type editing for table widget #19181
Conversation
Integrates Date picker component inside table's date column Property controls for date picker
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Fixes datepicker not opening on edit icon click for date column issue - CSS fixes for date picker input - Cleans up some unnecessary code
- adds time precision - adds shortcuts - adds first day of week - remove date column properties from other column types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the commented code
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Data.ts
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Data.ts
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/General.ts
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/General.ts
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Validations/Date.ts
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Validations/Date.ts
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Validations/Date.ts
Show resolved
Hide resolved
Removes commented code Adds cypress tests for Date Column Editing feature (WIP)
Adds test cases for few properties
…3682-date-column-editing-table-widget
…3682-date-column-editing-table-widget
Code clean up
/ok-to-test sha=2d65712 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3829845942. |
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Data.ts
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Data.ts
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/General.ts
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/component/cellComponents/DateCell.tsx
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/component/cellComponents/DateCell.tsx
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/component/cellComponents/DateCell.tsx
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/component/cellComponents/DateCell.tsx
Outdated
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/component/cellComponents/DateCell.tsx
Show resolved
Hide resolved
app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Validations/Number.ts
Outdated
Show resolved
Hide resolved
/ok-to-test sha=527dfa7 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3900056529. |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts |
…3682-date-column-editing-table-widget
/ok-to-test sha=9b8bb3c |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3908563604. |
The following are new failures, please fix them before merging the PR |
/perf-test sha=9b8bb3c |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3910081974. |
Tested this PR and LGTM
|
/perf-test sha=9b8bb3c |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3928912846. |
Description
PRD - https://www.notion.so/appsmith/Date-and-date-time-in-table-c9e292188eff4604a9f2b3c91aca1efb
Fixes #13682
Type of change
How Has This Been Tested?
Test Plan
TestSmith Test plan link: https://github.com/appsmithorg/TestSmith/issues/2157
Issues raised during DP testing
Checklist:
Dev activity
QA activity: