Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Date column type editing for table widget #19181

Merged
merged 23 commits into from Jan 16, 2023

Conversation

souma-ghosh
Copy link
Contributor

@souma-ghosh souma-ghosh commented Dec 23, 2022

  • Integrates Date picker component inside table's date column
  • Enables edit mode for date type column in table widget
  • Adds all the required Property controls for date picker
  • Builds the user flow for date column editing in table widget

Description

PRD - https://www.notion.so/appsmith/Date-and-date-time-in-table-c9e292188eff4604a9f2b3c91aca1efb

Fixes #13682

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Cypress

Test Plan

TestSmith Test plan link: https://github.com/appsmithorg/TestSmith/issues/2157

  • Test that user can make date type column editable
  • Test user able to edit date after turning on editable for date column
  • Test that changing display format in property pane changes date format in table
  • Test that Validation section, Events section and Date Settings section in property pane are visible only when Editable toggle is turned on
  • Test that setting max and min date in property pane works correctly while editing date
  • Test that after turning on Required in Validation shows proper validation message in the date cell when user clears the date cell by editing it
  • Test that Date Settings section, min date, max date are available only for date type columns in property controls
  • Test that changing First day of week changes the first day in the table's date cell calendar and shows proper validation message for invalid inputs
  • Test that Show Shortcuts toggle enables shortcuts in table cell's date picker and shortcuts work as expected
  • Test that while Adding New Row the date cell behaves like other editable cells
  • Test that App level CSS themes are correctly applied to Date Picker for Date cells

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

Integrates Date picker component inside table's date column
Property controls for date picker
@vercel
Copy link

vercel bot commented Dec 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 5:13AM (UTC)

- Fixes datepicker not opening on edit icon click for date column issue
- CSS fixes for date picker input
- Cleans up some unnecessary code
- adds time precision
- adds shortcuts
- adds first day of week
- remove date column properties from other column types
Copy link
Contributor

@keyurparalkar keyurparalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the commented code

Removes commented code
Adds cypress tests for Date Column Editing feature (WIP)
Adds test cases for few properties
@github-actions github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Community Reported issues reported by community members Enhancement New feature or request High This issue blocks a user from building or impacts a lot of users Table Widget labels Jan 2, 2023
@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=2d65712

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3829845942.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2d65712.
PR: 19181.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19181&runId=3829845942_1

@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=527dfa7

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3900056529.
Workflow: Appsmith External Integration Test Workflow.
Commit: 527dfa7.
PR: 19181.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19181&runId=3900056529_1

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2TextPagination_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_Table_Widget_API_Derived_Column_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableV2WithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableWithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug16377_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitImport/ImportEmptyRepo_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Connection_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DeleteBranch_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DisconnectGit_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Merge_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RegenerateSSHKey_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RepoLimitExceededErrorModal_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitWithTheming/GitWithTheming_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ApplicationURL_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ForkApplication_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_onClickAction_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_onOptionChange_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Derived_Column_Data_validation_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/CurlImportFlow_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2TextPagination_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_Table_Widget_API_Derived_Column_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableV2WithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableV2WithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableWithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug16377_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DeleteBranch_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ApplicationURL_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_To_App_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_onClickAction_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_onOptionChange_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Derived_Column_Data_validation_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/CurlImportFlow_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2TextPagination_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_Table_Widget_API_Derived_Column_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableV2WithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableV2WithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableWithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug16377_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DeleteBranch_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ApplicationURL_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_onClickAction_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_onOptionChange_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Derived_Column_Data_validation_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/CurlImportFlow_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts

@github-actions
Copy link

The following are new failures, please fix them before merging the PR cypress/integration/Smoke_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableTextPagination_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_TableV2TextPagination_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_Table_Widget_API_Derived_Column_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableV2WithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableV2WithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Binding/Bind_dataToTableWithSnipingMode_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/BugTests/Bug16377_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitDiscardChange/DiscardChanges_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/DeleteBranch_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/Deploy_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/RepoLimitExceededErrorModal_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Git/GitSync/SwitchBranches_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ApplicationURL_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/ApplicationURL_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/OtherUIFeatures/Logs_spec.ts
cypress/integration/Smoke_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/AppPageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/DatasourcePageLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorComment_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/VisualTests/WidgetsLayout_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Button/Button_onClickAction_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Dropdown/Dropdown_onOptionChange_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Form/FormWidget_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Derived_Column_Data_validation_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV1/Table_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/TableV2/TableV2_Property_JsonUpdate_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Edit_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/API_Response_View_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/ApiTests/CurlImportFlow_spec.js
cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/JSFunctionExecution_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/JsFunctionExecution/SetTimeout_spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts
cypress/integration/Smoke_TestSuite/ServerSideTests/OnLoadTests/ExecuteAction_Spec.ts

@souma-ghosh
Copy link
Contributor Author

/ok-to-test sha=9b8bb3c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3908563604.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9b8bb3c.
PR: 19181.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19181&runId=3908563604_1

@github-actions
Copy link

The following are new failures, please fix them before merging the PR

@souma-ghosh
Copy link
Contributor Author

/perf-test sha=9b8bb3c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3910081974.
Workflow: Performance Tests Workflow.
Commit: 9b8bb3c.
PR: 19181.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19181&runId=3910081974_1

@chandannkumar
Copy link

Tested this PR and LGTM

  • Tested date type column editing functionality
  • Tested with all Table properties like Adding a row, sorting, search, Filter, Update mode, SSP
  • Tested functionality on migration
  • Tested on older apps as well

@chandannkumar chandannkumar added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Jan 13, 2023
@souma-ghosh souma-ghosh dismissed keyurparalkar’s stale review January 13, 2023 13:23

Code has been cleaned up

@souma-ghosh
Copy link
Contributor Author

/perf-test sha=9b8bb3c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3928912846.
Workflow: Performance Tests Workflow.
Commit: 9b8bb3c.
PR: 19181.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=19181&runId=3928912846_1

@somangshu somangshu merged commit 12ea1b8 into release Jan 16, 2023
@somangshu somangshu deleted the feat/13682-date-column-editing-table-widget branch January 16, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Viewers Pod This label assigns issues to the app viewers pod Community Reported issues reported by community members Enhancement New feature or request High This issue blocks a user from building or impacts a lot of users Table Widget Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support editing date column type in table widget
5 participants