From f759439daeb744750a41a06642befb512c85bb26 Mon Sep 17 00:00:00 2001 From: Goutham Pratapa Date: Fri, 10 May 2024 17:15:05 +0530 Subject: [PATCH 1/3] [ops]: add warning for custom APPSMITH_GIT_ROOT --- deploy/docker/fs/opt/appsmith/run-with-env.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/deploy/docker/fs/opt/appsmith/run-with-env.sh b/deploy/docker/fs/opt/appsmith/run-with-env.sh index 93a7bf65fc9..960933f1478 100755 --- a/deploy/docker/fs/opt/appsmith/run-with-env.sh +++ b/deploy/docker/fs/opt/appsmith/run-with-env.sh @@ -30,6 +30,8 @@ fi if [[ -z "${APPSMITH_GIT_ROOT:-}" ]]; then export APPSMITH_GIT_ROOT=/appsmith-stacks/git-storage +else + echo "WARNING: It appears a custom value has been configured for APPSMITH_GIT_ROOT. This behaviour is deprecated and will soon be removed." fi mkdir -pv "$APPSMITH_GIT_ROOT" From 091b5755618991d4261213b62f379dae5c7fa928 Mon Sep 17 00:00:00 2001 From: Goutham Pratapa Date: Fri, 24 May 2024 15:34:18 +0530 Subject: [PATCH 2/3] add warning during backups --- deploy/docker/fs/opt/appsmith/utils/bin/backup.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/deploy/docker/fs/opt/appsmith/utils/bin/backup.js b/deploy/docker/fs/opt/appsmith/utils/bin/backup.js index a6fd65b23eb..571a3cbcbbb 100644 --- a/deploy/docker/fs/opt/appsmith/utils/bin/backup.js +++ b/deploy/docker/fs/opt/appsmith/utils/bin/backup.js @@ -134,6 +134,11 @@ async function createGitStorageArchive(destFolder) { const gitRoot = getGitRoot(process.env.APPSMITH_GIT_ROOT); + if (gitRoot != "/appsmith-stacks/git-storage/"){ + console.log('WARNING: It appears a custom value has been configured for APPSMITH_GIT_ROOT.'+ + ' This behaviour is deprecated and will soon be removed.') + } + await executeCopyCMD(gitRoot, destFolder) console.log('Created git-storage archive'); From 5866588e230c7815a32d3b34e7ca97a7549e5a9d Mon Sep 17 00:00:00 2001 From: Goutham Pratapa Date: Mon, 27 May 2024 15:19:15 +0530 Subject: [PATCH 3/3] chore: remove log message in backup --- deploy/docker/fs/opt/appsmith/utils/bin/backup.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/deploy/docker/fs/opt/appsmith/utils/bin/backup.js b/deploy/docker/fs/opt/appsmith/utils/bin/backup.js index 571a3cbcbbb..a6fd65b23eb 100644 --- a/deploy/docker/fs/opt/appsmith/utils/bin/backup.js +++ b/deploy/docker/fs/opt/appsmith/utils/bin/backup.js @@ -134,11 +134,6 @@ async function createGitStorageArchive(destFolder) { const gitRoot = getGitRoot(process.env.APPSMITH_GIT_ROOT); - if (gitRoot != "/appsmith-stacks/git-storage/"){ - console.log('WARNING: It appears a custom value has been configured for APPSMITH_GIT_ROOT.'+ - ' This behaviour is deprecated and will soon be removed.') - } - await executeCopyCMD(gitRoot, destFolder) console.log('Created git-storage archive');