Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Anvil widget name component rendering #33672

Merged
merged 7 commits into from
May 23, 2024

Commits on May 22, 2024

  1. Interact with a hovered widget's widget name component

    - Add a ghost component that prevents the widget underneath the widget
      name component from being focused
    - Select widget when dragging a focused widget from the widget name
      component
    - Adjust offsets and sizes of the ghost component and the widget name
      button
    - Remove onMouseLeave events from widgets and add an onMouseLeave event
      to the Canvas.
    riodeuno committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6764b07 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50a9b0a View commit details
    Browse the repository at this point in the history
  3. feat: Anvil: Enable parent selection for focused widget (#33649)

    ## Description
    - If the parent is already selected, disable parent selection
    - Introduce the selector to check if parent is selected.
    
    
    Fixes #33648 
    
    ## Automation
    
    /ok-to-test tags="@tag.Anvil"
    
    ### 🔍 Cypress test results
    <!-- This is an auto-generated comment: Cypress test results  -->
    > [!CAUTION]  
    > If you modify the content in this section, you are likely to disrupt
    the CI result for your PR.
    
    <!-- end of auto-generated comment: Cypress test results  -->
    
    
    ## Communication
    Should the DevRel and Marketing teams inform users about this change?
    - [ ] Yes
    - [x] No
    riodeuno committed May 22, 2024
    Configuration menu
    Copy the full SHA
    303a7e1 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Configuration menu
    Copy the full SHA
    5c8a8bf View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feat/drag-widget-name-component-on-hover' of https://gi…

    …thub.com/appsmithorg/appsmith into feat/drag-widget-name-component-on-hover
    riodeuno committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4373df8 View commit details
    Browse the repository at this point in the history
  3. Performance Fixes - Anvil Widget Name Component rendering

    - Ask floating UI to recompute more frequently to make sure the widget
      and widget name component don't stray away when users interact quickly
    
    - Add a widget name component to the DOM tree only if they're supposed
      to be visible
    riodeuno committed May 23, 2024
    Configuration menu
    Copy the full SHA
    8a9ac19 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

    …o perf/anvil-widget-name-component-rendering
    riodeuno committed May 23, 2024
    Configuration menu
    Copy the full SHA
    db2487d View commit details
    Browse the repository at this point in the history