Skip to content

fix: Add white-space CSS to span tag #9626 - #9708

Merged
somangshu merged 2 commits into
appsmithorg:releasefrom
rayrny:FIX/fix-9626-space-in-text-widget
Jan 6, 2022
Merged

fix: Add white-space CSS to span tag #9626#9708
somangshu merged 2 commits into
appsmithorg:releasefrom
rayrny:FIX/fix-9626-space-in-text-widget

Conversation

@rayrny

@rayrny rayrny commented Dec 11, 2021

Copy link
Copy Markdown
Contributor

Description

I fixed an issue where whitespace was not properly reflected in the text widget. I found that the CSS for white-space doesn't exist, and I added it.

Fixes #9626

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually and also Jest unit tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@welcome

welcome Bot commented Dec 11, 2021

Copy link
Copy Markdown

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗

@rayrny
rayrny marked this pull request as draft December 11, 2021 14:02
@rayrny
rayrny marked this pull request as ready for review December 11, 2021 14:05
@rayrny rayrny closed this Dec 11, 2021
@rayrny rayrny reopened this Dec 11, 2021
@mohanarpit

Copy link
Copy Markdown
Member

/ok-to-test sha=f5a1f8f

@github-actions

Copy link
Copy Markdown

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1569109870.
Workflow: Appsmith External Integration Test Workflow.
Commit: f5a1f8f.
PR: 9708.

@mohanarpit
mohanarpit requested a review from marks0351 December 12, 2021 09:01
@marks0351

Copy link
Copy Markdown
Contributor

@Jerimo spaces are recognised now but there seems to a mismatch in amount of space cud u check it out.
bug

@rayrny

rayrny commented Dec 13, 2021

Copy link
Copy Markdown
Contributor Author

@marks0351 ok. I'll work on it.

@github-actions

Copy link
Copy Markdown

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions Bot added the Stale label Dec 20, 2021

@marks0351 marks0351 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jerimo pls let me know if you are stuck on something.

@rayrny

rayrny commented Dec 22, 2021

Copy link
Copy Markdown
Contributor Author

@marks0351 Oh thank you, I didn't spend a lot of time on it these days. I'll try little more and contact you soon.

@github-actions github-actions Bot removed the Stale label Dec 22, 2021
@rayrny

rayrny commented Dec 27, 2021

Copy link
Copy Markdown
Contributor Author

sorry for the late response @marks0351 . In my opinion, the data displayed in the text widget has the correct number of spaces. Changing the <span> to <pre> doesn't seem to be a problem. I think it's because of the font, what do you think?

스크린샷 2021-12-27 오후 4 45 54

스크린샷 2021-12-27 오후 4 45 45

@marks0351 marks0351 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea i see that the spaces are accurately shown but the pixels used for each space on the editor vs on the widget seem to different.

@marks0351

Copy link
Copy Markdown
Contributor

@Jerimo can u pls pull latest release?

@vercel

vercel Bot commented Jan 1, 2022

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Appsmith Team on Vercel.

A member of the Team first needs to authorize it.

@rayrny

rayrny commented Jan 1, 2022

Copy link
Copy Markdown
Contributor Author

@marks0351 i'm done. cud u check it out?

@marks0351

Copy link
Copy Markdown
Contributor

/ok-to-test sha=36a16a1

@github-actions

github-actions Bot commented Jan 3, 2022

Copy link
Copy Markdown

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1648156075.
Workflow: Appsmith External Integration Test Workflow.
Commit: 36a16a1.
PR: 9708.

@marks0351

Copy link
Copy Markdown
Contributor

/ok-to-test sha=36a16a1

@github-actions

github-actions Bot commented Jan 3, 2022

Copy link
Copy Markdown

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1649754364.
Workflow: Appsmith External Integration Test Workflow.
Commit: 36a16a1.
PR: 9708.

@vercel

vercel Bot commented Jan 3, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/8HEBAzHDfzodSGnEmwvYCQ9vtWvz
✅ Preview: https://appsmith-git-fork-jerimo-fix-fix-9626-space-d2ed66-get-appsmith.vercel.app

@marks0351

Copy link
Copy Markdown
Contributor

merging his PR because the failing cases are unrelated to the PR

@marks0351
marks0351 enabled auto-merge (squash) January 6, 2022 14:37
@marks0351
marks0351 disabled auto-merge January 6, 2022 14:37
@somangshu
somangshu merged commit c15445a into appsmithorg:release Jan 6, 2022
leotom2000 pushed a commit that referenced this pull request Jan 6, 2022
Co-authored-by: goorm <goorm@RayKim.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Space is not reflected in the text widget.

5 participants