Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #61 #167

Open
wants to merge 3 commits into
base: master
from
Open

Conversation

@devtronic
Copy link

devtronic commented Dec 16, 2019

While the iOS device is rotating the bounds of the previewView will be recalculated
and the scanRect will be reinitialized.

Changes in the WorkspaceSettings are necessary to run the example app

While the iOS device is rotating the bounds of the previewView will be recalculated
and the scanRect will be reinitialized

Changes in the WorkspaceSettings are necessary to run the example app
@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Dec 27, 2019

Any news on this?

@rjahn

This comment has been minimized.

Copy link

rjahn commented Jan 2, 2020

... is it possible to test this fix?

@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Jan 2, 2020

Only directly on a iOS device by running the example app. I tested it with my iPhone XR with iOS 13.3

@rjahn

This comment has been minimized.

Copy link

rjahn commented Jan 2, 2020

Ok, only with example app? I have my own app with the latest dependency. I guess this won't work?

@rjahn

This comment has been minimized.

Copy link

rjahn commented Jan 2, 2020

.... not clear enough:
I tried to add the dependency as follows:

barcode_scan:
git:
url: https://github.com/apptreesoftware/flutter_barcode_reader.git
ref: master

@rjahn

This comment has been minimized.

Copy link

rjahn commented Jan 2, 2020

If I rotate before showing the scanner, the interface has the right width. If I have portrait and open show the scanner, rotate it before scanning - the width doesn't change!

@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Jan 2, 2020

You've to checkout the fix_issue_61 branch from the forked repo (https://github.com/mintware-de/flutter_barcode_reader/tree/fix_issue_61)

@rjahn

This comment has been minimized.

Copy link

rjahn commented Jan 2, 2020

OK, this branch works. But is it correct that the scan area is higher than the device height (landscape mode)? The green corner markers are not fully visible....

@DavideBicego

This comment has been minimized.

Copy link

DavideBicego commented Jan 8, 2020

This works ok but the Overlay area needs to be recalculated too so that it doesn't go out of screen.
I've tested in an iPhone 6 running iOS 12.4.4

@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Jan 8, 2020

I'll fix the size of the overlay this week

@rjahn

This comment has been minimized.

Copy link

rjahn commented Jan 8, 2020

Great!

@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Jan 12, 2020

I'm still working on the fix for the overlay

@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Jan 12, 2020

Finally 😎

IMG_0983

@rjahn

This comment has been minimized.

Copy link

rjahn commented Jan 12, 2020

Looks great, will try it asap!

@rjahn

This comment has been minimized.

Copy link

rjahn commented Jan 13, 2020

Verified, works great! Ready to merge?

@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Jan 15, 2020

@matthewtsmith it would be great if you could take a look on this, thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.