Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Flash On / Off text variable #54

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@devtronic
Copy link

devtronic commented Nov 4, 2018

The text for "Flash On" and "Flash Off" can now be passed to the scan method
String barcode = await BarcodeScanner.scan("Flash On", "Flash Off");

  • Android only
  • Also kotlin version and build tools version updated
The text for "Flash On" and "Flash Off" can now be passed to the scan…
… method

- Android only
- Also kotlin version and build tools version updated
@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Dec 11, 2018

Any reasons why this PR is not getting merged?

@matthewtsmith

This comment has been minimized.

Copy link
Member

matthewtsmith commented Dec 11, 2018

Sorry for the slow reply. I have a couple issues with the PR as it stands now.

  • We strongly believe that all features should be cross platform.
  • I think the API should take in an Options class that can be passed into the scan() method. This would allow us to extend the options over time without creating a bunch of arguments in the scan method.

The call to open the scanner would look like

scan(options: new ScanOptions(flashOnText: "Flash On", flashOffText: "Flash Off"))

The Options class constructor should have reasonable defaults. the options should allow null and if so, apply some reasonable defaults.

@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Dec 11, 2018

Thank you for your reply. I'll fix that asap.

@KamilZielinski

This comment has been minimized.

Copy link

KamilZielinski commented Mar 13, 2019

@devtronic Are you going to continue work on this API extension?

@devtronic

This comment has been minimized.

Copy link
Author

devtronic commented Mar 13, 2019

Hi, yes I've bought a MacBook that I can also extend and test the iOS code.

Merge remote-tracking branch 'upstream/master'
# Conflicts:
#	example/android/build.gradle
#	example/android/gradle/wrapper/gradle-wrapper.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.