New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPVEYOR_PULL_REQUEST_REPO_NAME and APPVEYOR_PULL_REQUEST_REPO_BRANCH variables #1435

Closed
IlyaFinkelshteyn opened this Issue Mar 22, 2017 · 13 comments

Comments

Projects
None yet
5 participants
@IlyaFinkelshteyn
Member

IlyaFinkelshteyn commented Mar 22, 2017

Discussion

Exact variable names:

  • APPVEYOR_PULL_REQUEST_REPO_NAME
  • APPVEYOR_PULL_REQUEST_REPO_BRANCH

Also according to another discussion we might need to add

  • APPVEYOR_PULL_REQUEST_HEAD_COMMIT_ID

@FeodorFitsner FeodorFitsner modified the milestone: 2-Apr-2017 Mar 23, 2017

@IlyaFinkelshteyn IlyaFinkelshteyn self-assigned this Mar 23, 2017

@IlyaFinkelshteyn IlyaFinkelshteyn changed the title from Extract and expose and environment variables PR_REPO_NAME and PR_REPO_BRANCH to Extract and expose as environment variables PR_REPO_NAME and PR_REPO_BRANCH Mar 23, 2017

@FeodorFitsner FeodorFitsner changed the title from Extract and expose as environment variables PR_REPO_NAME and PR_REPO_BRANCH to APPVEYOR_PULL_REQUEST_REPO_NAME and APPVEYOR_PULL_REQUEST_REPO_BRANCH variables Mar 23, 2017

@Rondom

This comment has been minimized.

Show comment
Hide comment
@Rondom

Rondom Mar 26, 2017

I hope it is okay to mention another issue here.
If you decide to implement this issue, it would not be much work to implement the "before-push-sha1" as well, because both enhancements are done probably in the same parts of the code.
#1157

Rondom commented Mar 26, 2017

I hope it is okay to mention another issue here.
If you decide to implement this issue, it would not be much work to implement the "before-push-sha1" as well, because both enhancements are done probably in the same parts of the code.
#1157

@IlyaFinkelshteyn

This comment has been minimized.

Show comment
Hide comment
@IlyaFinkelshteyn

IlyaFinkelshteyn May 8, 2017

Member

The following variables are in production (for GitHub only now):
APPVEYOR_PULL_REQUEST_HEAD_COMMIT
APPVEYOR_PULL_REQUEST_HEAD_REPO_NAME
APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH

Keeping this issue opened, until #1157 added + the same at least for BitBucket

Member

IlyaFinkelshteyn commented May 8, 2017

The following variables are in production (for GitHub only now):
APPVEYOR_PULL_REQUEST_HEAD_COMMIT
APPVEYOR_PULL_REQUEST_HEAD_REPO_NAME
APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH

Keeping this issue opened, until #1157 added + the same at least for BitBucket

@IlyaFinkelshteyn

This comment has been minimized.

Show comment
Hide comment
@IlyaFinkelshteyn

IlyaFinkelshteyn May 8, 2017

Member

Yes... We though it would be more self-explaining name if include HEAD...

Member

IlyaFinkelshteyn commented May 8, 2017

Yes... We though it would be more self-explaining name if include HEAD...

@ivailop

This comment has been minimized.

Show comment
Hide comment
@ivailop

ivailop May 9, 2017

I just tried it for both fork and branch PR builds and found that APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH is never set.

ivailop commented May 9, 2017

I just tried it for both fork and branch PR builds and found that APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH is never set.

@IlyaFinkelshteyn

This comment has been minimized.

Show comment
Hide comment
@IlyaFinkelshteyn

IlyaFinkelshteyn May 9, 2017

Member

I tried this today in the morning with this simple test and it worked. Can you please point me to the repro in public repository?

Member

IlyaFinkelshteyn commented May 9, 2017

I tried this today in the morning with this simple test and it worked. Can you please point me to the repro in public repository?

@ivailop

This comment has been minimized.

Show comment
Hide comment
@ivailop

ivailop May 9, 2017

fork PR - https://ci.appveyor.com/project/munderseth/build-box/build/1.0.100
branch PR - https://ci.appveyor.com/project/munderseth/build-box/build/1.0.101

In both cases APPVEYOR_PULL_REQUEST_HEAD_COMMIT and APPVEYOR_PULL_REQUEST_HEAD_REPO_NAME were properly set. But APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH was not.

ivailop commented May 9, 2017

fork PR - https://ci.appveyor.com/project/munderseth/build-box/build/1.0.100
branch PR - https://ci.appveyor.com/project/munderseth/build-box/build/1.0.101

In both cases APPVEYOR_PULL_REQUEST_HEAD_COMMIT and APPVEYOR_PULL_REQUEST_HEAD_REPO_NAME were properly set. But APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH was not.

@ivailop

This comment has been minimized.

Show comment
Hide comment
@ivailop

ivailop May 9, 2017

The mentioned above builds were reruns. I just tried again with a new build and it worked all fine. Sorry for creating any unnecessary noise.

ivailop commented May 9, 2017

The mentioned above builds were reruns. I just tried again with a new build and it worked all fine. Sorry for creating any unnecessary noise.

@IlyaFinkelshteyn

This comment has been minimized.

Show comment
Hide comment
@IlyaFinkelshteyn

IlyaFinkelshteyn May 9, 2017

Member

Oh, thanks for clarification, this is not unnecessary noise! I believe we can make it work for reruns and calls from API too.

Member

IlyaFinkelshteyn commented May 9, 2017

Oh, thanks for clarification, this is not unnecessary noise! I believe we can make it work for reruns and calls from API too.

@IlyaFinkelshteyn

This comment has been minimized.

Show comment
Hide comment
@IlyaFinkelshteyn

IlyaFinkelshteyn May 19, 2017

Member

This is still not fully completed

Member

IlyaFinkelshteyn commented May 19, 2017

This is still not fully completed

@IlyaFinkelshteyn IlyaFinkelshteyn modified the milestones: 21-May-2017, 14-May-2017 May 19, 2017

@IlyaFinkelshteyn

This comment has been minimized.

Show comment
Hide comment
@IlyaFinkelshteyn

IlyaFinkelshteyn Jun 8, 2017

Member

@ivailop now for rerun it works too. Still keeping the issue open as not everything requested is done.

Member

IlyaFinkelshteyn commented Jun 8, 2017

@ivailop now for rerun it works too. Still keeping the issue open as not everything requested is done.

@Megamouse

This comment has been minimized.

Show comment
Hide comment
@Megamouse

Megamouse Sep 21, 2017

https://www.appveyor.com/docs/environment-variables/

I guess they are missing here, unless I am blind.
Sorry for posting on this closed issue but didn't want to open a new one just for that

Megamouse commented Sep 21, 2017

https://www.appveyor.com/docs/environment-variables/

I guess they are missing here, unless I am blind.
Sorry for posting on this closed issue but didn't want to open a new one just for that

@IlyaFinkelshteyn

This comment has been minimized.

Show comment
Hide comment
@IlyaFinkelshteyn
Member

IlyaFinkelshteyn commented Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment