New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL 1.0.2p #2558

Closed
FeodorFitsner opened this Issue Aug 14, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@FeodorFitsner
Member

FeodorFitsner commented Aug 14, 2018

No description provided.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Aug 30, 2018

This upgrade made it no longer possible to vcpkg install grpc on AppVeyor and has broken our build. I did not get any errors prior to this change and the build worked fine. Please see: Microsoft/vcpkg#4189

RobertBColton commented Aug 30, 2018

This upgrade made it no longer possible to vcpkg install grpc on AppVeyor and has broken our build. I did not get any errors prior to this change and the build worked fine. Please see: Microsoft/vcpkg#4189

@FeodorFitsner

This comment has been minimized.

Show comment
Hide comment
@FeodorFitsner

FeodorFitsner Aug 30, 2018

Member

Why do you think the issue is related to OpenSSL update? Could you please elaborate?

Member

FeodorFitsner commented Aug 30, 2018

Why do you think the issue is related to OpenSSL update? Could you please elaborate?

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Aug 30, 2018

I ran my build that does vcpkg install grpc on AppVeyor with the same environment setup (Visual Studio 2017 image) just about an hour before you guys did the update. I thought I had the build perfect but then had to rerun it just after the update was deployed to AppVeyor and then the build failed. The only difference I could see in the log was the Visual Studio version.

Before/working: https://ci.appveyor.com/project/enigma-dev/radialgm-deps/build/1.0.57/job/ftn0ck64kpccv7mo#L4
After/not working (triggered by "New Build" UI button with no other changes at all): https://ci.appveyor.com/project/enigma-dev/radialgm-deps/build/1.0.58/job/45cn3iff0u9ce8p1#L4

Here is the organization's repo and also I should mention that I just switched back to image: Previous Visual Studio 2017 and the build went green.
enigma-dev/RadialGM-deps@4155f59
https://ci.appveyor.com/project/enigma-dev/radialgm-deps/build/1.0.64

So basically, I believe my issue is related to this pull request and the updates by the process of elimination and the fact that I've observed this in a sort of controlled experiment way. I hope that you will look into this further, thank you.

RobertBColton commented Aug 30, 2018

I ran my build that does vcpkg install grpc on AppVeyor with the same environment setup (Visual Studio 2017 image) just about an hour before you guys did the update. I thought I had the build perfect but then had to rerun it just after the update was deployed to AppVeyor and then the build failed. The only difference I could see in the log was the Visual Studio version.

Before/working: https://ci.appveyor.com/project/enigma-dev/radialgm-deps/build/1.0.57/job/ftn0ck64kpccv7mo#L4
After/not working (triggered by "New Build" UI button with no other changes at all): https://ci.appveyor.com/project/enigma-dev/radialgm-deps/build/1.0.58/job/45cn3iff0u9ce8p1#L4

Here is the organization's repo and also I should mention that I just switched back to image: Previous Visual Studio 2017 and the build went green.
enigma-dev/RadialGM-deps@4155f59
https://ci.appveyor.com/project/enigma-dev/radialgm-deps/build/1.0.64

So basically, I believe my issue is related to this pull request and the updates by the process of elimination and the fact that I've observed this in a sort of controlled experiment way. I hope that you will look into this further, thank you.

@FeodorFitsner

This comment has been minimized.

Show comment
Hide comment
@FeodorFitsner

FeodorFitsner Aug 30, 2018

Member

But why do you think it’s both VS 15.8.1 and OpenSSL updates broke the build? You posted the same comment in two issues.

Member

FeodorFitsner commented Aug 30, 2018

But why do you think it’s both VS 15.8.1 and OpenSSL updates broke the build? You posted the same comment in two issues.

@FeodorFitsner

This comment has been minimized.

Show comment
Hide comment
@FeodorFitsner

FeodorFitsner Aug 30, 2018

Member

Looks like installing OpenSSL 1.1 regressed that: Microsoft/vcpkg#4189 (comment)

Member

FeodorFitsner commented Aug 30, 2018

Looks like installing OpenSSL 1.1 regressed that: Microsoft/vcpkg#4189 (comment)

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Aug 30, 2018

Sorry about that but I wasn't really absolutely certain myself at that point which of the updates caused it and wanted to make sure to bring attention to it. I'm glad the issue has been rooted out and appreciate the quick turn around!

RobertBColton commented Aug 30, 2018

Sorry about that but I wasn't really absolutely certain myself at that point which of the updates caused it and wanted to make sure to bring attention to it. I'm glad the issue has been rooted out and appreciate the quick turn around!

coryan added a commit to coryan/google-cloud-cpp that referenced this issue Aug 31, 2018

Fix AppVeyor builds.
AppVeyor upgraded their images in the last 24 hours:

https://www.appveyor.com/updates/

This update installs OpenSSL in:

C:\OpenSSL-v11-Win64
C:\OpenSSL-v11-Win32

unfortunately that gets picked up by CMake and the build breaks.
Apparently the intention is to remove these directories in the next
image:

https://github.com/appveyor/ci/milestone/95
appveyor/ci#2600
appveyor/ci#2558 (comment)

Meanwhile the workaround is to manually delete them:

Microsoft/vcpkg#4189 (comment)

For extra joy, the new compiler in this image also requires a new
version of googletest:

google/googletest#1620

coryan added a commit to GoogleCloudPlatform/google-cloud-cpp that referenced this issue Aug 31, 2018

Fix AppVeyor builds. (#1064)
AppVeyor upgraded their images in the last 24 hours:

https://www.appveyor.com/updates/

This update installs OpenSSL in:

C:\OpenSSL-v11-Win64
C:\OpenSSL-v11-Win32

unfortunately that gets picked up by CMake and the build breaks.
Apparently the intention is to remove these directories in the next
image:

https://github.com/appveyor/ci/milestone/95
appveyor/ci#2600
appveyor/ci#2558 (comment)

Meanwhile the workaround is to manually delete them:

Microsoft/vcpkg#4189 (comment)

For extra joy, the new compiler in this image also requires a new
version of googletest:

google/googletest#1620

@FeodorFitsner FeodorFitsner added Hyper-V and removed Hyper-V labels Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment