New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS 2017] MSVC 19.15.26726.0 fails to correclty compile constexpr #2598

Open
JohanMabille opened this Issue Aug 29, 2018 · 10 comments

Comments

Projects
None yet
3 participants
@JohanMabille

JohanMabille commented Aug 29, 2018

MSVC 19.14.26433.0 has been recently updated to MSVC 19.15.26726.0; this leads to compilation error due to bad constexpr handling, as can be seen in this log.

The compilation was fine with the last MSVC (see here).

@FeodorFitsner

This comment has been minimized.

Show comment
Hide comment
@FeodorFitsner

FeodorFitsner Aug 30, 2018

Member

VS 2017 has been updated to 15.8.1.

Wondering if it's been fixed in 15.8.2?

Member

FeodorFitsner commented Aug 30, 2018

VS 2017 has been updated to 15.8.1.

Wondering if it's been fixed in 15.8.2?

@FeodorFitsner FeodorFitsner added this to the next-images-update milestone Aug 30, 2018

@JohanMabille

This comment has been minimized.

Show comment
Hide comment
@JohanMabille

JohanMabille Aug 30, 2018

I hope so, however the release notes does not mention anything about that, and the 15.8.1 release notes only mentions a change that is totally unrelated to this problem.

Using "Previous Visual Studio 2017" as a workaround for now.

JohanMabille commented Aug 30, 2018

I hope so, however the release notes does not mention anything about that, and the 15.8.1 release notes only mentions a change that is totally unrelated to this problem.

Using "Previous Visual Studio 2017" as a workaround for now.

@FeodorFitsner

This comment has been minimized.

Show comment
Hide comment
@FeodorFitsner

FeodorFitsner Aug 30, 2018

Member

That's not cool. OK, let's hope 15.8.2 will fix that - we are going to deploy it tomorrow. Otherwise, you should report the issue, so it's fixed by Microsoft. "Previous" image won't stay the same forever, but eventually will be replaced with 15.8.x.

Member

FeodorFitsner commented Aug 30, 2018

That's not cool. OK, let's hope 15.8.2 will fix that - we are going to deploy it tomorrow. Otherwise, you should report the issue, so it's fixed by Microsoft. "Previous" image won't stay the same forever, but eventually will be replaced with 15.8.x.

@JohanMabille

This comment has been minimized.

Show comment
Hide comment
@JohanMabille

JohanMabille Aug 30, 2018

It seems that the 15.8 branch has some problems with constexpr handling (issue1, issue2) that will be fixed in 15.8.3 only (if not later for some of the issues).

Is there any mean on your side to test the build of one of these repos with the next version that will be deployed?
xtensor
mpark/variant

They make a heavy use of constexpr and if the builds fail, there is a chance that the next update will still break the build of many other projects.

JohanMabille commented Aug 30, 2018

It seems that the 15.8 branch has some problems with constexpr handling (issue1, issue2) that will be fixed in 15.8.3 only (if not later for some of the issues).

Is there any mean on your side to test the build of one of these repos with the next version that will be deployed?
xtensor
mpark/variant

They make a heavy use of constexpr and if the builds fail, there is a chance that the next update will still break the build of many other projects.

@IlyaFinkelshteyn

This comment has been minimized.

Show comment
Hide comment
@IlyaFinkelshteyn

IlyaFinkelshteyn Aug 30, 2018

Member

@JohanMabille as you see, this issue is assigned to next-images-update milestone. This means that this should be fixed before major (when we replace previous) image update.

We test our images with build repos we constantly add to https://github.com/appveyor-tests/. Can you create a more hello-world-style repo with appveyor.yml which will fail fast if this problem re-occurs so we can add it to our test repos too?

Member

IlyaFinkelshteyn commented Aug 30, 2018

@JohanMabille as you see, this issue is assigned to next-images-update milestone. This means that this should be fixed before major (when we replace previous) image update.

We test our images with build repos we constantly add to https://github.com/appveyor-tests/. Can you create a more hello-world-style repo with appveyor.yml which will fail fast if this problem re-occurs so we can add it to our test repos too?

@FeodorFitsner

This comment has been minimized.

Show comment
Hide comment
@FeodorFitsner
Member

FeodorFitsner commented Sep 13, 2018

@JohanMabille

This comment has been minimized.

Show comment
Hide comment
@JohanMabille

JohanMabille Sep 14, 2018

Awesome, thanks for this update! I hope it will fix most of our issues.

@IlyaFinkelshteyn I didn't forget you, I was really busy these last weeks; I should have more time now to start producing minimal test cases for the issues we experience with VS2017.

JohanMabille commented Sep 14, 2018

Awesome, thanks for this update! I hope it will fix most of our issues.

@IlyaFinkelshteyn I didn't forget you, I was really busy these last weeks; I should have more time now to start producing minimal test cases for the issues we experience with VS2017.

@JohanMabille

This comment has been minimized.

Show comment
Hide comment
@JohanMabille

JohanMabille Sep 17, 2018

The bug is still present in 15.8.4, the VS team confirmed they have a fix in 16.0.
By the way, we just created a repo with minimal examples to reproduces C++ compiler bugs, we hope it will help tracking and fixing these issues.

JohanMabille commented Sep 17, 2018

The bug is still present in 15.8.4, the VS team confirmed they have a fix in 16.0.
By the way, we just created a repo with minimal examples to reproduces C++ compiler bugs, we hope it will help tracking and fixing these issues.

@FeodorFitsner

This comment has been minimized.

Show comment
Hide comment
@FeodorFitsner

FeodorFitsner Sep 17, 2018

Member

Oh, damn. Let's re-open this issue then.

Is there a corresponding issue on VS website we can watch for?

Member

FeodorFitsner commented Sep 17, 2018

Oh, damn. Let's re-open this issue then.

Is there a corresponding issue on VS website we can watch for?

@JohanMabille

This comment has been minimized.

Show comment
Hide comment
@JohanMabille

JohanMabille Sep 17, 2018

Yes, this issue is really similar to the one we have.

JohanMabille commented Sep 17, 2018

Yes, this issue is really similar to the one we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment