Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2019 version 16.0.0 Preview 2.1 #2834

Closed
EwoutH opened this Issue Jan 30, 2019 · 9 comments

Comments

Projects
None yet
5 participants
@EwoutH
Copy link

EwoutH commented Jan 30, 2019

Would be nice if the Visual Studio 2019 Preview image could be updated to VS2019 Preview 2 with the windows-images-update-2019-02-03 milestone.

@FeodorFitsner FeodorFitsner changed the title Update to Visual Studio 2019 Preview 2 Visual Studio 2019 version 16.0.0 Preview 2.0 Jan 31, 2019

@VladislavAntonyuk

This comment has been minimized.

Copy link

VladislavAntonyuk commented Feb 3, 2019

Version 2.1 is released

@FeodorFitsner FeodorFitsner changed the title Visual Studio 2019 version 16.0.0 Preview 2.0 Visual Studio 2019 version 16.0.0 Preview 2.1 Feb 3, 2019

@EwoutH

This comment has been minimized.

Copy link
Author

EwoutH commented Feb 10, 2019

And Preview 2.2 also

@IlyaFinkelshteyn

This comment has been minimized.

Copy link
Member

IlyaFinkelshteyn commented Feb 12, 2019

New Windows images deployed

@jskeet

This comment has been minimized.

Copy link

jskeet commented Feb 12, 2019

Is it expected that there's any delay between them being deployed and being available? I'm still getting errors about the right version of the .NET Core SDK not being present:

A compatible installed dotnet SDK for global.json version: [3.0.100-preview-010184] from [C:\projects\nodatime\global.json] was not found
Please install the [3.0.100-preview-010184] SDK or update [C:\projects\nodatime\global.json] with an installed dotnet SDK:
  1.0.0-preview2-003156 [C:\Program Files\dotnet\sdk]
  1.0.1 [C:\Program Files\dotnet\sdk]
  1.0.2 [C:\Program Files\dotnet\sdk]
  1.0.3 [C:\Program Files\dotnet\sdk]
  1.0.4 [C:\Program Files\dotnet\sdk]
  1.1.0 [C:\Program Files\dotnet\sdk]
  2.0.0 [C:\Program Files\dotnet\sdk]
  2.0.2 [C:\Program Files\dotnet\sdk]
  2.0.3 [C:\Program Files\dotnet\sdk]
  2.1.2 [C:\Program Files\dotnet\sdk]
  2.1.4 [C:\Program Files\dotnet\sdk]
  2.1.100 [C:\Program Files\dotnet\sdk]
  2.1.101 [C:\Program Files\dotnet\sdk]
  2.1.103 [C:\Program Files\dotnet\sdk]
  2.1.104 [C:\Program Files\dotnet\sdk]
  2.1.105 [C:\Program Files\dotnet\sdk]
  2.1.200 [C:\Program Files\dotnet\sdk]
  2.1.201 [C:\Program Files\dotnet\sdk]
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.300 [C:\Program Files\dotnet\sdk]
  2.1.301 [C:\Program Files\dotnet\sdk]
  2.1.302 [C:\Program Files\dotnet\sdk]
  2.1.400 [C:\Program Files\dotnet\sdk]
  2.1.401 [C:\Program Files\dotnet\sdk]
  2.1.402 [C:\Program Files\dotnet\sdk]
  2.1.403 [C:\Program Files\dotnet\sdk]
  2.1.500 [C:\Program Files\dotnet\sdk]
  2.1.502 [C:\Program Files\dotnet\sdk]
  2.1.503 [C:\Program Files\dotnet\sdk]
  2.1.600-preview-009426 [C:\Program Files\dotnet\sdk]
  2.1.600-preview-009472 [C:\Program Files\dotnet\sdk]
  2.2.100 [C:\Program Files\dotnet\sdk]
  2.2.103 [C:\Program Files\dotnet\sdk]
  3.0.100-preview-009812 [C:\Program Files\dotnet\sdk]
@IlyaFinkelshteyn

This comment has been minimized.

Copy link
Member

IlyaFinkelshteyn commented Feb 12, 2019

@jskeet can you please send a link to the build?

@jskeet

This comment has been minimized.

Copy link

jskeet commented Feb 12, 2019

https://ci.appveyor.com/project/nodatime/nodatime/builds/22299705

That was triggered via hitting "New Build". If that doesn't use new images, that would explain things, but I'd (perhaps naively) expect it to pick up the latest one.

@IlyaFinkelshteyn

This comment has been minimized.

Copy link
Member

IlyaFinkelshteyn commented Feb 12, 2019

@jskeet Thank you, I found it. Visual Studio is actually updated on Visual Studio 2019 Preview image (which you can check if you RDP to build VM and press Help > About in VS). However this does not automatically installed last runtime and SDK.

Please check my fork build history with workaround. Changes are self-explainable. I did not send a PR as you probably prefer to wrap that workaround into script in you own way.

Filed #2862 to add this to the Visual Studio 2019 Preview.

However I am not sure you really need this image. If you install SDK and runtime on the fly using standard Visual Studio 2017 image you will enjoy faster build start because main images are on "pre-heated" VMs.

@jskeet

This comment has been minimized.

Copy link

jskeet commented Feb 12, 2019

Great, thanks very much. Will make that change now.

@jskeet

This comment has been minimized.

Copy link

jskeet commented Feb 12, 2019

Looks like it's working: nodatime/nodatime#1281
Note that I haven't installed the runtime separately - just the SDK, as that includes the runtime as far as I'm aware.

At least, the build works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.