Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ninja 1.9.0 and Meson 0.52.1 #2835

Closed
EwoutH opened this issue Jan 30, 2019 · 11 comments
Closed

Ninja 1.9.0 and Meson 0.52.1 #2835

EwoutH opened this issue Jan 30, 2019 · 11 comments

Comments

@EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Jan 30, 2019

Meson and Ninja are gaining popularity quickly. It's a relatively fast install, but it adds a lot of code for two very small programs that could be installed by default.

@Zingam

This comment has been minimized.

Copy link

@Zingam Zingam commented Jan 30, 2019

CMake is best served with Ninja. Visual Studio's CMake integration works with Ninja by default. So basically it is defacto the standard on Windows. Appveyor has CMake... so there is really no reason not to have it integrated by default.

@IlyaFinkelshteyn IlyaFinkelshteyn added this to the vs-2019-image milestone May 28, 2019
@EwoutH

This comment has been minimized.

Copy link
Contributor Author

@EwoutH EwoutH commented Dec 9, 2019

@IlyaFinkelshteyn Could you give a status update on this issue?

@FeodorFitsner

This comment has been minimized.

Copy link
Member

@FeodorFitsner FeodorFitsner commented Dec 9, 2019

Ninja could be easily downloaded during the build. It's just a few KB zip: https://github.com/ninja-build/ninja/releases

@EwoutH

This comment has been minimized.

Copy link
Contributor Author

@EwoutH EwoutH commented Dec 9, 2019

It saves a few lines of code in a lot of .yml files. Just because it's just a few kB's, it could easily be provided with the image.

@pavelkryukov

This comment has been minimized.

Copy link

@pavelkryukov pavelkryukov commented Dec 9, 2019

Also, downloading sometimes fails and build has to be restarted

@Zingam

This comment has been minimized.

Copy link

@Zingam Zingam commented Dec 10, 2019

Ninja usage with CMake is ubiquitous. It simply makes no sense to have CMake but not to have Ninja, especially because it is just a few KBs.

@EwoutH

This comment has been minimized.

Copy link
Contributor Author

@EwoutH EwoutH commented Jan 20, 2020

Thanks a lot!

@Zingam

This comment has been minimized.

Copy link

@Zingam Zingam commented Jan 20, 2020

@FeodorFitsner Is Ninja also available on the Ubuntu image along CMake?

@Wasapl

This comment has been minimized.

Copy link
Contributor

@Wasapl Wasapl commented Jan 22, 2020

Ninja is not preinstalled on the Ubuntu images but it's very easy to install it from pre-built package. Just add next block into your appveyor.yml file:

install:
  - sh: sudo apt-get install ninja-build
@Zingam

This comment has been minimized.

Copy link

@Zingam Zingam commented Jan 22, 2020

@Wasapl Sure but it would make sense to not have to do it if your script supports Windows and Ubuntu. I would like to have as little discrepancies between platforms as possible in my scripts.

@Wasapl

This comment has been minimized.

Copy link
Contributor

@Wasapl Wasapl commented Jan 22, 2020

Fair enough, we will add Ninja on next update of Ubuntu and MACOS images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.