Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt 5.12.3, 5.12.4, 5.13.0 #2923

Closed
tsteven4 opened this issue Apr 24, 2019 · 8 comments

Comments

@tsteven4
Copy link

commented Apr 24, 2019

Please add Qt 5.12.3 to the next-images-update milestone.

@IlyaFinkelshteyn IlyaFinkelshteyn added this to the next-images-update milestone Apr 24, 2019

@patrickelectric

This comment has been minimized.

Copy link

commented Jun 17, 2019

Update the title to 5.12.4 ;), Since a newer version is available
https://blog.qt.io/blog/2019/06/17/qt-5-12-4-released-support-openssl-1-1-1/

@IlyaFinkelshteyn IlyaFinkelshteyn changed the title Qt 5.12.3 Qt 5.12.4 Jun 17, 2019

@nschimme

This comment has been minimized.

Copy link

commented Jul 10, 2019

Please note that Qt 5.12.4 requires OpenSSL 1.1.1 as opposed to OpenSSL 1.0.2 in previous 5.12.x versions. This will most likely cause user builds to fail... but with OpenSSL 1.0.2 being slated for EOL by end of this year maybe it's a good thing to break the builds.

@heydojo

This comment has been minimized.

Copy link

commented Jul 18, 2019

Please note that Qt 5.12.4 requires OpenSSL 1.1.1 as opposed to OpenSSL 1.0.2 in previous 5.12.x versions. This will most likely cause user builds to fail... but with OpenSSL 1.0.2 being slated for EOL by end of this year maybe it's a good thing to break the builds.

This change in Qt is generally a sensible one IMO but not for a LTS point release. There was no need to remove backwards compatibility with Openssl 1.0.2 (if what you say is true.) The differences between 5.12.3 and 5.12.4 are causing lots of problems. Such as that vcpkg is now stuck on 5.12.3 because there are breaking changes in Qt 5.12.4 that they are struggling to work around.

Maybe it would be possible to ensure that both Qt 5.12.3 and Qt 5.12.4 are available? Some developers may not be ready to move away from Qt 5.12.3 just yet.

@IlyaFinkelshteyn IlyaFinkelshteyn changed the title Qt 5.12.4 Qt 5.12.3, 5.12.4, 5.13.0 Aug 1, 2019

@tsteven4

This comment has been minimized.

Copy link
Author

commented Aug 1, 2019

@IlyaFinkelshteyn

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

We did not risk that because we heard about big number of issues with 5.12.4. You can check this script and see how to modify it (or part of it) and run at init or install stage to do changes you need.

@tsteven4

This comment has been minimized.

Copy link
Author

commented Aug 1, 2019

@IlyaFinkelshteyn

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

What happens with 12.3/12.4 is an exception, rather than a rule. Usually we keep only x.x.latest and make a mapping for x.x to x.x.latest. In this case we did not take a risk to break many people and kept 12.3 as default in parallel. For next update after 12.4 we will probably come back to the regular approach.

@nschimme

This comment has been minimized.

Copy link

commented Aug 2, 2019

I have not found any issues with Qt 5.12.4 either. My project uses OpenSSL but I was able to have it switch to 1.1.1 without any issues by just packaging the correct DLLs:
https://github.com/MUME/MMapper/pull/150/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.