Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectre-mitigated MFC libraries missing for VS2017 #3011

Closed
manxorist opened this issue Jun 30, 2019 · 4 comments

Comments

@manxorist
Copy link

commented Jun 30, 2019

Spectre-mitigated MFC libraries are missing from the VS2017 install.
From the install script, it looks like also spectre-mitigated ATL and Runtime libraries are also missing.

This causes OpenMPT build to fail, see https://ci.appveyor.com/project/OpenMPT/openmpt/builds/25641443 :

LINK : fatal error LNK1104: cannot open file 'afxnmcd.lib' [C:\projects\openmpt\build\vs2017win7\OpenMPT.vcxproj]

On a related note: Were MFC libraries missed in appveyor/build-images@5c16b97 ? They are a separate option from ATL spectre-mitigated libraries in the GUI installer.

@manxorist manxorist changed the title Specre-mitigated MFC libraries missing for VS2017 Spectre-mitigated MFC libraries missing for VS2017 Jun 30, 2019

@FeodorFitsner FeodorFitsner added this to the next-images-update milestone Jul 3, 2019

@heydojo

This comment has been minimized.

Copy link

commented Jul 13, 2019

It would be greatly appreciated if this issue is addressed in the VS2019 image too please.
Please make all Spectre mitigations available to compile against.
Thanks!

@IlyaFinkelshteyn

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

@manxorist can you please provide exact name of the component as it looks in the in the Visual Studio Installer UI? To ensure this is needed component, you can add blocking RDP at init stage of the build, add that component with UI and then continue the build and see if it fixed the problem. Or if you 100% sure of the component name, please post it here exactly as it appears in installer UI.
We appreciate if you can do this in next couple of days as we are finalizing images updates this week.

@manxorist

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

The missing required VS2017 components are named "Visual C++ ATL (x86/x64) with Spectre Mitigations" and "Visual C++MFC for x86/x64 with Spectre Mitigations" in the installer UI.

http://manx.datengang.de/openmpt/temp/vs2017-mfc-spectre.png

@IlyaFinkelshteyn

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

@manxorist great, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.