Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS 3.04 on Visual Studio 2019 #3019

Closed
mikejsavage opened this issue Jul 6, 2019 · 1 comment

Comments

@mikejsavage
Copy link

commented Jul 6, 2019

At the bottom of https://ci.appveyor.com/project/mikejsavage/forksow-launcher/builds/25789573

"C:\Program Files (x86)\NSIS\makensis.exe" -DONLY_WRITE_UNINSTALLER installer\installer.nsi
The system cannot find the path specified.

appveyor.yml looks like this:

version: "{build}"
clone_depth: 1
image: Visual Studio 2019

build_script:
- call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" x86_amd64
- scripts\lua.exe make.lua release > build.ninja
- scripts\ninja.exe -v -k 0
- scripts\ducible.exe release\cocainediesel.exe
- scripts\ducible.exe release\elevate_for_update.exe
- scripts\ducible.exe release\headlessupdater.exe
- '"C:\Program Files (x86)\NSIS\makensis.exe" -DONLY_WRITE_UNINSTALLER installer\installer.nsi'
- installer\CocaineDieselInstaller.exe /S
- '"C:\Program Files (x86)\NSIS\makensis.exe" installer\installer.nsi'

artifacts:
- path: installer/CocaineDieselInstaller.exe
- path: release
  name: launcher_windows

It doesn't work if you do just makensis.exe without the full path either, and looking at vs2019.json it appears that NSIS does not get installed

@IlyaFinkelshteyn

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Sure, we will add NSIS to Visual Studio 2019 image in next update. For now please use content of this script at install stage.

@IlyaFinkelshteyn IlyaFinkelshteyn added bug and removed bug labels Aug 31, 2019

@IlyaFinkelshteyn IlyaFinkelshteyn changed the title NSIS not installed in VS2019 image NSIS 3.04 on Visual Studio 2019 Aug 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.