Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2019 and VS2019P: "find: ' ': No such file or directory" #3147

Closed
SergeGautherie opened this issue Oct 16, 2019 · 12 comments
Closed

VS2019 and VS2019P: "find: ' ': No such file or directory" #3147

SergeGautherie opened this issue Oct 16, 2019 · 12 comments

Comments

@SergeGautherie
Copy link
Contributor

@SergeGautherie SergeGautherie commented Oct 16, 2019

It looks like https://www.appveyor.com/updates/2019/10/13/ caused a "regression".

--

https://ci.appveyor.com/project/SergeGautherie/reactos/builds/28185866

call %APPVEYOR_BUILD_FOLDER%\configure.cmd %clang_configure_option%
find: ' ': No such file or directory
find: 'cmake version': No such file or directory
Unable to find cmake, if it is installed, check your PATH variable.
Command exited with code 1
@SergeGautherie

This comment has been minimized.

Copy link
Contributor Author

@SergeGautherie SergeGautherie commented Oct 16, 2019

Guess: related to issue 3133?

@FeodorFitsner

This comment has been minimized.

Copy link
Member

@FeodorFitsner FeodorFitsner commented Oct 16, 2019

You mean this issue: #3133? It was fixed, actually. Could it be another reason you get regression? In line 38 you are getting a "different" cmake, not cmake 3.15.1 installed by default and available in the PATH.

@SergeGautherie

This comment has been minimized.

Copy link
Contributor Author

@SergeGautherie SergeGautherie commented Oct 16, 2019

You mean this issue: #3133?

Yes.

It was fixed, actually.

Yes, I am wondering whether that fix could have caused this regression. Only a guess...

Could it be another reason you get regression?

Sure. You know more than me what changed in that update...

In line 38 you are getting a "different" cmake, not cmake 3.15.1 installed by default and available in the PATH.

Yes, that project uses its own custom CMake and updated PATH. As you can see, it has always worked fine, before the last image update.
(always = long time use of default VS2015 image, recently started trying VS2019 image.)

@FeodorFitsner

This comment has been minimized.

Copy link
Member

@FeodorFitsner FeodorFitsner commented Oct 17, 2019

If your build was using/depending bash.exe from WSL distribution then you can move it back in PATH to have precedence and give it another try. Other than that it's hard to tell why the build is broken. I can only suggest to hop into VM via RDP and see what's going on there.

@SergeGautherie

This comment has been minimized.

Copy link
Contributor Author

@SergeGautherie SergeGautherie commented Oct 17, 2019

If your build was using/depending bash.exe from WSL distribution

Project default is to use VS2015 image with x32/VS2010 and x64/VS2015. These builds still succeed.
Were/Are they affected by that bash/WSL issue?

move it back in PATH to have precedence and give it another try

What should I add to my appveyor.yml to test that?

@SergeGautherie SergeGautherie changed the title VS2019: "find: ' ': No such file or directory" VS2019 and VS2019P: "find: ' ': No such file or directory" Oct 17, 2019
@SergeGautherie

This comment has been minimized.

Copy link
Contributor Author

@SergeGautherie SergeGautherie commented Nov 9, 2019

After https://www.appveyor.com/updates/2019/11/08/ ,
Preview/Regular are not fixed, Previous is now broken too,

Then, ReactOS project cannot be built with (any) VS2019 anymore :-(
See https://ci.appveyor.com/project/SergeGautherie/reactos/builds/28732003

@SergeGautherie

This comment has been minimized.

Copy link
Contributor Author

@SergeGautherie SergeGautherie commented Nov 9, 2019

I commented out updating the PATH: same broken result (but current cmake version).
https://ci.appveyor.com/project/SergeGautherie/reactos/builds/28732135

@SergeGautherie

This comment has been minimized.

Copy link
Contributor Author

@SergeGautherie SergeGautherie commented Nov 9, 2019

Git find.exe is used instead of Windows one :-/ (Wrong install option? Intended?)
And using a pipe, as in xxx | find "yyy" fails!
See https://ci.appveyor.com/project/SergeGautherie/reactos/builds/28732472

Workaround: del "C:\Program Files\Git\usr\bin\find.exe".

@FeodorFitsner

This comment has been minimized.

Copy link
Member

@FeodorFitsner FeodorFitsner commented Nov 9, 2019

Good finding! Indeed, while building image we put C:\Program Files\Git\usr\bin in front of PATH, so git's bash.exe has precedence over WSL's C:\Windows\System32\bash.exe. I kind of agree that hiding native find (and possibly other utilities) doesn't look good. What would be solution here?

@FeodorFitsner

This comment has been minimized.

Copy link
Member

@FeodorFitsner FeodorFitsner commented Nov 9, 2019

I think renaming C:\Windows\System32\bash.exe to something like wsl-bash.exe would be a better solution rather than pushing forward git's bin directory. If anyone needs WSL's bash in their builds they could rename it back. I added a new issue to fix in the next update: #3193

@SergeGautherie

This comment has been minimized.

Copy link
Contributor Author

@SergeGautherie SergeGautherie commented Nov 9, 2019

What would be solution here?

With regard to WSL (bash.exe), I am not familiar with it and I don't know what requirements/issues are on AppVeyor.

With regard to Git, when I install v2.10 locally, I can choose from 3 PATH options: nothing, Git only, Git and utilities. I choose 'Git only', which is recommended (to avoid such overlaps) and enough (for my usual use)...
PS: It even explicitly warns about find (and sort)!
GIT210-Install_find-sort

@SergeGautherie

This comment has been minimized.

Copy link
Contributor Author

@SergeGautherie SergeGautherie commented Dec 10, 2019

VS2019:
fixed by https://www.appveyor.com/updates/2019/12/09/ :-)
(Git now comes later than System32, in the PATH.)

VS2019 Preview:
will hopefully be fixed on its next update (of all other tools too: 7-Zip, CMake, ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.