Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio 2019 version 16.4.3 #3281

Closed
cugone opened this issue Jan 15, 2020 · 0 comments
Closed

Visual Studio 2019 version 16.4.3 #3281

cugone opened this issue Jan 15, 2020 · 0 comments

Comments

@cugone
Copy link

@cugone cugone commented Jan 15, 2020

Problem Description
There is a breaking regression change to the code gen for vector::reverse_iterator operator-> in C++17 x64 builds introduced prior to and still present in 16.4.2. This affects any project that uses the GMock test library or any code that uses vector::reverse_iterator operator-> directly.

The Visual Studio team released version 16.4.3 that fixes the issue on January 14, 2020.

Original code gen issue: https://developercommunity.visualstudio.com/content/problem/847490/msvc-codegen-error-vector-reverse-iterator-x64-c17.html?childToView=861565
GMock related-issue: https://developercommunity.visualstudio.com/content/problem/851616/googlemock-crashes-when-compiling-with-c17-selecte.html?inRegister=true
MS VS 2019 16.4.3 Release Notes listing the above code gen issue as fixed: https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes#16.4.3

Since this is a fix for a breaking change that affects a widely used library, updating as soon as possible would be helpful.

Solution

Update the Visual Studio 2019 image to use version 16.4.3 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.