Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt 5.14.1 #3310

Closed
FeodorFitsner opened this issue Feb 5, 2020 · 28 comments
Closed

Qt 5.14.1 #3310

FeodorFitsner opened this issue Feb 5, 2020 · 28 comments

Comments

@FeodorFitsner
Copy link
Member

@FeodorFitsner FeodorFitsner commented Feb 5, 2020

No description provided.

@FeodorFitsner FeodorFitsner added this to the next-images-update milestone Feb 5, 2020
@vadi2

This comment has been minimized.

Copy link

@vadi2 vadi2 commented Feb 24, 2020

It would seem it's important because mingw got broken in 5.14.0: https://forum.qt.io/topic/111926/qmake-5-14-0-linking-behaviour-changed-breaks-build/2

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Feb 24, 2020

This is how you can install MinGW package of 5.14.1 during the build:

iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/build-images/master/scripts/Windows/install_qt_module.ps1'))
Install-QtComponent -Version '5.14.1' -Name 'win32_mingw73' -ExcludeDocs -ExcludeExamples
@vadi2

This comment has been minimized.

Copy link

@vadi2 vadi2 commented Feb 24, 2020

Thanks a lot! It failed with the following unfortunately:

Error: Qt license file was not found!
Project ERROR: License check failed! Giving up ...

https://ci.appveyor.com/project/Mudlet/mudlet/builds/31024264

Anything I can do?

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Feb 24, 2020

Right, forgot one more line. Corrected snippet:

iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/build-images/master/scripts/Windows/install_qt_module.ps1'))
Install-QtComponent -Version '5.14.1' -Name 'win32_mingw73' -ExcludeDocs -ExcludeExamples
ConfigureQtVersion 'C:\Qt' '5.14.1'
@nschimme

This comment has been minimized.

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 4, 2020

@nschimme are those dependencies part of the main Qt MinGW package?

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 4, 2020

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 4, 2020

@nschimme other words, what options would you choose to install if doing that locally with UI installer?

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 4, 2020

@FeodorFitsner Usually just the main package which is what I did. I'm going to try calling qtenv2.bat next.

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 4, 2020

@nschimme another idea: login to build VM via RDP, go to C:\Qt and run maintenance tool. Install 5.14.1 package and then continue build. If that works I will be looking for issue in "fast" installer.

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 5, 2020

@nschimme did you manage to work?

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 5, 2020

@FeodorFitsner I'm down with a cold. I wasn't able to pick it up again yet.

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 5, 2020

@nschimme sorry to hear that. Get well soon!

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 6, 2020

@FeodorFitsner I managed to get a brief window of clarity to try this. I'm unable to run the Maintenance Tool since my personal account doesn't have a license to run on this platform ???

Okay, so I used the script to download and install Qt 5.13.1 and it worked without a problem. I'm guessing the script doesn't fully support 5.14.1 in some manner.

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 20, 2020

@FeodorFitsner did you see my update above?

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 20, 2020

@nschimme so, you mean it's not the way Qt installed, but Qt 5.14.1 itself didn't work for your project?

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 21, 2020

@FeodorFitsner No, the script works only on version less than Qt 5.14.0. I've now upgraded to using the latest MSVC 2019 image and I'm running into the exact same error.

https://ci.appveyor.com/project/nschimme/mmapper/builds/31616514/job/8m8t55h0qmplrg9a

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 21, 2020

So, what's missing? What would you choose if installing via UI?

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 21, 2020

Default Qt5 MinGW install. It's just somehow not being set up right.

@vadi2 Do you want to give it another shot? Maybe it's my build but I doubt it.

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 21, 2020

What options do you choose on the dialog below to install 5.14.1 on your machine?

image

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 21, 2020

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 21, 2020

Thanks, will look into that tomorrow for any discrepancies.

Of course, it would be great to have a "base line" meaning you have a build that works when you RDP into build worker and install 5.14.1 with Qt maintenance tool, so we know it's our hack to install Qt breaks the build.

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 21, 2020

@FeodorFitsner Yeah, for some reason I was running into a license issue when I tried it last.

I'm unfortunately out of ideas as of now. I've reverted my build to not use MSYS and it's still failing.

https://ci.appveyor.com/project/nschimme/mmapper/builds/31616838/job/h02i3eqedqtqwvo2

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 21, 2020

You don't need a license to install it, just Qt login. It's a recent requirement that open-source installations require login.

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 21, 2020

I did a clean install of Qt 5.14.1 MinGW 7.3.0 32-bit component using Qt installer (left pane) and then compared file-by-file (~45K files) with the folder (right pane) produced by our unattended installer. Here are the results:

image

Essential folders 5.14.1\mingw73_32 and Tools\mingw730_32 are identical. QtCreator is quite different - don't know if you use it, vcredist is optional too. All the rest looks like supplementary (meta)data for online installer.

What can further help me to investigate the problem is the detailed log from your Qt installer.

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 28, 2020

@FeodorFitsner I found the problem! Using Qt 5.14.0 or higher with MinGW you cannot provide the --release or --debug flags with windeployqt or it'll puke. You need to let windeployqt self-detect this. I'll try and file a bug upstream.

MUME/MMapper@63f3ddf

@FeodorFitsner

This comment has been minimized.

Copy link
Member Author

@FeodorFitsner FeodorFitsner commented Mar 30, 2020

Cool, thanks for the update!

@nschimme

This comment has been minimized.

Copy link

@nschimme nschimme commented Mar 30, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.