From e67c7e73223d2299bbeccdc6e69d76a9de1a06b3 Mon Sep 17 00:00:00 2001 From: Steven Nguyen Date: Wed, 21 Feb 2024 18:44:30 -0800 Subject: [PATCH] fix(messaging): fix user targets modal title and description The title and description should be different depending on whether you're adding a target to a message or a target to a topic. --- .../project-[project]/messaging/actions.svelte | 6 +++++- .../topic-[topic]/subscribers/+page.svelte | 16 +++++++++++++++- .../messaging/userTargetsModal.svelte | 11 +++-------- 3 files changed, 23 insertions(+), 10 deletions(-) diff --git a/src/routes/console/project-[project]/messaging/actions.svelte b/src/routes/console/project-[project]/messaging/actions.svelte index 110779982..f52264348 100644 --- a/src/routes/console/project-[project]/messaging/actions.svelte +++ b/src/routes/console/project-[project]/messaging/actions.svelte @@ -36,10 +36,14 @@ dispatch('addTopics', e.detail); }} /> { showUserTargets = false; dispatch('addTargets', e.detail); - }} /> + }}> + Select existing targets to which you want to send this message. + diff --git a/src/routes/console/project-[project]/messaging/topics/topic-[topic]/subscribers/+page.svelte b/src/routes/console/project-[project]/messaging/topics/topic-[topic]/subscribers/+page.svelte index 27219e4e0..08d6fd58a 100644 --- a/src/routes/console/project-[project]/messaging/topics/topic-[topic]/subscribers/+page.svelte +++ b/src/routes/console/project-[project]/messaging/topics/topic-[topic]/subscribers/+page.svelte @@ -146,4 +146,18 @@ {/if} - + + +

+ Add subscribers to this topic by selecting the targets for directing messages. Learn more about subscribers. +

+
+
diff --git a/src/routes/console/project-[project]/messaging/userTargetsModal.svelte b/src/routes/console/project-[project]/messaging/userTargetsModal.svelte index 827b3fe15..7552144aa 100644 --- a/src/routes/console/project-[project]/messaging/userTargetsModal.svelte +++ b/src/routes/console/project-[project]/messaging/userTargetsModal.svelte @@ -12,10 +12,10 @@ import { createEventDispatcher } from 'svelte'; import ProviderType from './providerType.svelte'; + export let title: string; export let show: boolean; export let targetsById: Record; export let providerType: MessagingProviderType = null; - export let title = 'Select subscribers'; const dispatch = createEventDispatcher(); @@ -118,13 +118,8 @@ -

- Add subscribers to this topic by selecting the targets for directing messages. Learn more about subscribers. -

+ +